[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

Ah, I'll want to figure out how to emit local aliases to dso_local as a 
follow-up of D72197 , but that should be 
orthogonal to what you want to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[pre-merge checks [bot] via Phabricator via cfe-commits]

merge_guards_bot added a comment.

{icon check-circle color=green} Unit tests: pass. 61856 tests passed, 0 failed 
and 781 were skipped.

{icon question-circle color=gray} clang-tidy: unknown.

{icon check-circle color=green} clang-format: pass.

Build artifacts 
: 
diff.json 
,
 clang-format.patch 
,
 CMakeCache.txt 
,
 console-log.txt 
,
 test-results.xml 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D72724#1820392 , @serge-sans-paille 
wrote:

> @MaskRay: is that okay with you if I start implementing 
> -fsemantic-interposition based on `dso_preemptable`?


I haven't done anything in this area. Go ahead:) I'd like to help or review if 
you need anything from me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[Fangrui Song via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG5d1b3ba68769: [Driver] Ignore -fno-semantic-interposition 
(authored by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724

Files:
  clang/include/clang/Driver/Options.td
  clang/test/Driver/clang_f_opts.c


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -251,6 +251,7 @@
 // RUN: -fexec-charset=UTF-8 \
 // RUN: -fivopts -fno-ivopts  \
 // RUN: -fnon-call-exceptions -fno-non-call-exceptions\
+// RUN: -fno-semantic-interposition   \
 // RUN: -fpermissive -fno-permissive  \
 // RUN: -fdefer-pop -fno-defer-pop\
 // RUN: -fprefetch-loop-arrays -fno-prefetch-loop-arrays  \
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3258,6 +3258,7 @@
 defm ipa_cp : BooleanFFlag<"ipa-cp">,
 Group;
 defm ivopts : BooleanFFlag<"ivopts">, 
Group;
+def : Flag<["-"], "fno-semantic-interposition">, Group;
 defm non_call_exceptions : BooleanFFlag<"non-call-exceptions">, 
Group;
 defm peel_loops : BooleanFFlag<"peel-loops">, 
Group;
 defm permissive : BooleanFFlag<"permissive">, Group;


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -251,6 +251,7 @@
 // RUN: -fexec-charset=UTF-8 \
 // RUN: -fivopts -fno-ivopts  \
 // RUN: -fnon-call-exceptions -fno-non-call-exceptions\
+// RUN: -fno-semantic-interposition   \
 // RUN: -fpermissive -fno-permissive  \
 // RUN: -fdefer-pop -fno-defer-pop\
 // RUN: -fprefetch-loop-arrays -fno-prefetch-loop-arrays  \
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3258,6 +3258,7 @@
 defm ipa_cp : BooleanFFlag<"ipa-cp">,
 Group;
 defm ivopts : BooleanFFlag<"ivopts">, Group;
+def : Flag<["-"], "fno-semantic-interposition">, Group;
 defm non_call_exceptions : BooleanFFlag<"non-call-exceptions">, Group;
 defm peel_loops : BooleanFFlag<"peel-loops">, Group;
 defm permissive : BooleanFFlag<"permissive">, Group;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D72724#1820362 , @serge-sans-paille 
wrote:

> LGTM


I don't follow Fedora news. It is just that a friend informed me of this 
-fno-semantic-interposition movement two days ago and I postulated that it was 
your motivation to ping that patch...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[serge via Phabricator via cfe-commits]

serge-sans-paille added a comment.

@MaskRay: is that okay with you if I start implementing 
-fsemantic-interposition based on `dso_preemptable`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[Fangrui Song via Phabricator via cfe-commits]

MaskRay updated this revision to Diff 238065.
MaskRay added a comment.

Use Flag<> instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724

Files:
  clang/include/clang/Driver/Options.td
  clang/test/Driver/clang_f_opts.c


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -251,6 +251,7 @@
 // RUN: -fexec-charset=UTF-8 \
 // RUN: -fivopts -fno-ivopts  \
 // RUN: -fnon-call-exceptions -fno-non-call-exceptions\
+// RUN: -fno-semantic-interposition   \
 // RUN: -fpermissive -fno-permissive  \
 // RUN: -fdefer-pop -fno-defer-pop\
 // RUN: -fprefetch-loop-arrays -fno-prefetch-loop-arrays  \
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3258,6 +3258,7 @@
 defm ipa_cp : BooleanFFlag<"ipa-cp">,
 Group;
 defm ivopts : BooleanFFlag<"ivopts">, 
Group;
+def : Flag<["-"], "fno-semantic-interposition">, Group;
 defm non_call_exceptions : BooleanFFlag<"non-call-exceptions">, 
Group;
 defm peel_loops : BooleanFFlag<"peel-loops">, 
Group;
 defm permissive : BooleanFFlag<"permissive">, Group;


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -251,6 +251,7 @@
 // RUN: -fexec-charset=UTF-8 \
 // RUN: -fivopts -fno-ivopts  \
 // RUN: -fnon-call-exceptions -fno-non-call-exceptions\
+// RUN: -fno-semantic-interposition   \
 // RUN: -fpermissive -fno-permissive  \
 // RUN: -fdefer-pop -fno-defer-pop\
 // RUN: -fprefetch-loop-arrays -fno-prefetch-loop-arrays  \
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3258,6 +3258,7 @@
 defm ipa_cp : BooleanFFlag<"ipa-cp">,
 Group;
 defm ivopts : BooleanFFlag<"ivopts">, Group;
+def : Flag<["-"], "fno-semantic-interposition">, Group;
 defm non_call_exceptions : BooleanFFlag<"non-call-exceptions">, Group;
 defm peel_loops : BooleanFFlag<"peel-loops">, Group;
 defm permissive : BooleanFFlag<"permissive">, Group;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[serge via Phabricator via cfe-commits]

serge-sans-paille accepted this revision.
serge-sans-paille added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[pre-merge checks [bot] via Phabricator via cfe-commits]

merge_guards_bot added a comment.

{icon check-circle color=green} Unit tests: pass. 61849 tests passed, 0 failed 
and 781 were skipped.

{icon question-circle color=gray} clang-tidy: unknown.

{icon check-circle color=green} clang-format: pass.

Build artifacts 
: 
diff.json 
,
 clang-format.patch 
,
 CMakeCache.txt 
,
 console-log.txt 
,
 test-results.xml 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72724/new/

https://reviews.llvm.org/D72724



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

[Fangrui Song via Phabricator via cfe-commits]

MaskRay created this revision.
MaskRay added reviewers: hfinkel, tstellar, Romain-Geissler-1A, 
serge-sans-paille.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Fedora wants to build projects with -fno-semantic-interposition (e.g.
https://fedoraproject.org/wiki/Changes/PythonNoSemanticInterpositionSpeedup),
which is supported by GCC>=5.

Clang's current behavior is similar to -fno-semantic-interposition and
the end goal is to make it more so
(https://lists.llvm.org/pipermail/llvm-dev/2016-November/107625.html).
Ignore this option.

We should let users know -fsemantic-interposition is not currently
supported, so it should remain a hard error.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72724

Files:
  clang/include/clang/Driver/Options.td
  clang/test/Driver/clang_f_opts.c


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -251,6 +251,7 @@
 // RUN: -fexec-charset=UTF-8 \
 // RUN: -fivopts -fno-ivopts  \
 // RUN: -fnon-call-exceptions -fno-non-call-exceptions\
+// RUN: -fno-semantic-interposition   \
 // RUN: -fpermissive -fno-permissive  \
 // RUN: -fdefer-pop -fno-defer-pop\
 // RUN: -fprefetch-loop-arrays -fno-prefetch-loop-arrays  \
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3258,6 +3258,7 @@
 defm ipa_cp : BooleanFFlag<"ipa-cp">,
 Group;
 defm ivopts : BooleanFFlag<"ivopts">, 
Group;
+defm no_semantic_interposition : BooleanFFlag<"no-semantic-interposition">, 
Group;
 defm non_call_exceptions : BooleanFFlag<"non-call-exceptions">, 
Group;
 defm peel_loops : BooleanFFlag<"peel-loops">, 
Group;
 defm permissive : BooleanFFlag<"permissive">, Group;


Index: clang/test/Driver/clang_f_opts.c
===
--- clang/test/Driver/clang_f_opts.c
+++ clang/test/Driver/clang_f_opts.c
@@ -251,6 +251,7 @@
 // RUN: -fexec-charset=UTF-8 \
 // RUN: -fivopts -fno-ivopts  \
 // RUN: -fnon-call-exceptions -fno-non-call-exceptions\
+// RUN: -fno-semantic-interposition   \
 // RUN: -fpermissive -fno-permissive  \
 // RUN: -fdefer-pop -fno-defer-pop\
 // RUN: -fprefetch-loop-arrays -fno-prefetch-loop-arrays  \
Index: clang/include/clang/Driver/Options.td
===
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -3258,6 +3258,7 @@
 defm ipa_cp : BooleanFFlag<"ipa-cp">,
 Group;
 defm ivopts : BooleanFFlag<"ivopts">, Group;
+defm no_semantic_interposition : BooleanFFlag<"no-semantic-interposition">, Group;
 defm non_call_exceptions : BooleanFFlag<"non-call-exceptions">, Group;
 defm peel_loops : BooleanFFlag<"peel-loops">, Group;
 defm permissive : BooleanFFlag<"permissive">, Group;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits