[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

This revision was automatically updated to reflect the committed changes. Closed by commit rG7596d3c50c4b: [objc_direct] Allow for direct messages be sent to `self` when it is a Class (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 ___ cfe-commits mailing list

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 239615. MadCoder added a comment. with the test for real CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp clang/test/SemaObjC/method-direct-arc.m

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 239610. MadCoder added a comment. adding the non ARC test I forgot to add CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp clang/test/SemaObjC/method-direct-arc.m

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 239477. MadCoder added a comment. fixed @ahatanak feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp clang/test/SemaObjC/method-direct-arc.m Index:

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

arphaman added a comment. Please add a test that exercises path without ARC enabled. Comment at: clang/lib/Sema/SemaExprObjC.cpp:3019 +if (ReceiverType->isObjCClassType() && !isImplicit && +(!Receiver->isObjCSelfExpr() || !getLangOpts().ObjCAutoRefCount)) {

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 238698. MadCoder added a comment. Added some more tests to make sure it works along inheritance chains as expected CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder created this revision. MadCoder added reviewers: ahatanak, arphaman, dexonsmith, erik.pilkington. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. Sending a message to `self` when it is const and within a class method is safe because we know that `self` is the