This revision was automatically updated to reflect the committed changes.
Closed by commit rG6324912592a1: [clangd] Simplify preferred vs
definition logic a bit in XRefs AST code. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall updated this revision to Diff 252690.
sammccall added a comment.
clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73369/new/
https://reviews.llvm.org/D73369
Files:
clang-tools-extra/clangd/XRefs.cpp
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:257
const NamedDecl *Def = getDefinition(D);
-const NamedDecl *Preferred = Def ? Def : D;
+if (const NamedDecl *C = llvm::dyn_cast(D->getCanonicalDecl()))
+ D = C;
sammccall updated this revision to Diff 252689.
sammccall marked 3 inline comments as done.
sammccall added a comment.
address comments, rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73369/new/
https://reviews.llvm.org/D73369
Files:
kadircet added a comment.
ping :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73369/new/
https://reviews.llvm.org/D73369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kadircet added a comment.
also please fix clang-tidy and format warnings
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73369/new/
https://reviews.llvm.org/D73369
___
cfe-commits mailing list
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:257
const NamedDecl *Def = getDefinition(D);
-const NamedDecl *Preferred = Def ? Def : D;
+if (const NamedDecl *C = llvm::dyn_cast(D->getCanonicalDecl()))
+ D = C;
merge_guards_bot added a comment.
{icon times-circle color=red} Unit tests: fail. 62173 tests passed, 5 failed
and 815 were skipped.
failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Now Preferred is always the canonical (first) decl, Definition is always the def
if available.
In
