[PATCH] D73891: [RISCV] Support experimental/unratified extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd1ee6dc076f: [RISCV] Support experimental/unratified extensions (authored by simoncook). Changed prior to commit: https://reviews.llvm.org/D73891?vs=250770=256369#toc Repository: rG LLVM Github

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

asb added a comment. I've approved D65649 now, so I think this one can land as soon as that one does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

asb accepted this revision. asb added a comment. LGTM, thanks Simon! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 ___ cfe-commits mailing list

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lenary accepted this revision. lenary added a comment. I'm happy with the approach here. At some point we should put version numbers into the target features, but I think that can wait until we know how to cope with how the `G` extension expands into its other extensions (this has some open

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lewis-revill accepted this revision. lewis-revill added a comment. This revision is now accepted and ready to land. Thanks, this is looking in good shape now. As long as everyone agrees on this scheme I think the implementation is good to go (pending the bitmanip extension support).

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 250770. simoncook added a comment. - Update to match latest dependencies - Handle adding "experimental-" to SubtargetFeatures for experimental features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 243502. simoncook added a comment. Rebase, incorporate changes suggested by Lewis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files:

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lewis-revill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:93 + // If experimental extension, require use of current version number number + if (auto ExperimentalExtension = isExperimentalExtension(Ext)) { +if

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 243325. simoncook added a comment. Add support for Z extensions also under this scheme. In order to support these I've had to tweak the multi-letter extension parsing a little. The net result is that error messages printed regarding version numbers are

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook planned changes to this revision. simoncook added a comment. With the update to D69987 adding the `Zvqmac` predicate, it seems both the `b` and `v` extensions have Z extensions that also need supporting using this method, I'll update this to also

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 242286. simoncook added a comment. Switch to using `Optional` for returning version numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files:

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook marked 2 inline comments as done. simoncook added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:50 +static bool isExperimentalExtension(StringRef Ext) { + // Currently 'b' is the only supported experimental extension

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:50 +static bool isExperimentalExtension(StringRef Ext) { + // Currently 'b' is the only supported experimental extension Suggestion: I think we can avoid these two

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 242080. simoncook added a comment. Don't put option in m_riscv_Features_Group, we don't want it being handled like a feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files:

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook created this revision. simoncook added reviewers: asb, lenary, PaoloS, s.egerton. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay,