[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein added a comment. These changes look reasonable to me, thanks! Here is a list of commits that we plan to cherrypick, see https://github.com/clangd/clangd/issues/417. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74025/new/

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

sammccall added a comment. @jaafar Thanks for the list, this is really useful for us. These all look reasonable to me, I've filed bugs to track them and if they look good to Haojian too we'll get them merged. See https://github.com/clangd/clangd/issues?q=is%3Aissue+label%3Acherrypick I've

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. Thnaks very much @hokein . The ones I need are: 9a5c448a31bacc08e73fcae4636094f9b6e2be6a eaf0c89ec5f866b6cef296c542c030bb2cf8481d

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein added a comment. In D74025#2076704 , @jaafar wrote: > Thank you. I'm trying to balance stability with getting the fixes I need and > so have been avoiding the "bleeding edge". I find that unfortunately the > newest code tends to be "unstable", as

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. Thank you. I'm trying to balance stability with getting the fixes I need and so have been avoiding the "bleeding edge". I find that unfortunately the newest code tends to be "unstable", as those releases are rightfully named, and I need clangd for my daily work. There

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein added a comment. In D74025#2073946 , @jaafar wrote: > I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or > 10.0.1-rc1 either. Is there any chance it can be released? unfortunately, it is not picked up in 10.0.0 release,

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or 10.0.1-rc1 either. Is there any chance it can be released? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74025/new/ https://reviews.llvm.org/D74025

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf0c89ec5f8: [clangd] Add the missing elaborated types in FindTarget. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74025?vs=242524=242566#toc Repository: rG LLVM Github

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62441 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74025 Files: