[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-06-08 Thread Erik Pilkington via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b529e311a90: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-28 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. In D74417#1876927 , @dgoldman wrote: > Okay, I've added this, it seems to fix the test but I'm not sure if it's > fully correct

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-14 Thread David Goldman via Phabricator via cfe-commits
dgoldman added a comment. In D74417#1874826 , @erik.pilkington wrote: > In D74417#1874747 , @dgoldman wrote: > > > Added but it's still failing due to a different assertion failure, do you > > think this could be

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-14 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 244728. dgoldman added a comment. - Fix parameter abbreviation for ParamVarDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files:

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-13 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. In D74417#1874747 , @dgoldman wrote: > Added but it's still failing due to a different assertion failure, do you > think this could be because the abbreviation is different for the ParamVars? > I'm not sure how to handle

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-13 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 244467. dgoldman added a comment. - Add test (fails due to different assertion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files:

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-13 Thread David Goldman via Phabricator via cfe-commits
dgoldman added a comment. In D74417#1873287 , @erik.pilkington wrote: > This looks good, but please add a testcase. Added but it's still failing due to a different assertion failure, do you think this could be because the abbreviation is different for

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-12 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. This looks good, but please add a testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 ___ cfe-commits mailing list

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-11 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added reviewers: erik.pilkington, jkorous. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. - This assertion will fire when functions are marked with