[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

This revision was automatically updated to reflect the committed changes. Closed by commit rG58817a0783ca: [clang][XCOFF] Indicate that XCOFF does not support COMDATs (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/docs/LangRef.rst:913 -Note that the Mach-O platform doesn't support COMDATs, and ELF and WebAssembly -only support ``any`` as a selection kind.

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty updated this revision to Diff 245201. daltenty added a comment. Herald added subscribers: aheejin, dschuff. - Update lang doc to indicate XCOFF doesn't support COMDAT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty added a comment. In D74631#1876995 , @sfertile wrote: > 1. We should probably update the COMDAT section of the lang ref to mention > XCOFF doesn't support COMDATS. I will update the langref as suggested. > 2. Will we report an error somewhere

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

Xiangling_L added a comment. In D74631#1876995 , @sfertile wrote: > > Will we report an error somewhere in the backend if we encounter a COMDAT? I hit this when I was doing my static init patch as well: `error in backend: COMDAT not yet supported

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

sfertile added a comment. 1. We should probably update the COMDAT section of the lang ref to mention XCOFF doens't support COMDATS. 2. Will we report an error somewhere in the backend if we encounter a COMDAT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ https://reviews.llvm.org/D74631 Files: clang/test/CodeGen/xcoff-comdat.cpp

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty created this revision. daltenty added reviewers: stevewan, sfertile, Xiangling_L. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline XCOFF