[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. > If that happens, this Phabricator review does not close automatically. It has > to be closed manually using the "Add Action..." dropdown. Noted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

Meinersbur closed this revision. Meinersbur added a comment. In D74801#189 , @baziotis wrote: > I committed that > (https://reviews.llvm.org/rG21390eab4c05e0ed7e7d13ada9e85f62b87ea484) but as > it seems, I should have added the differential division

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. I committed that (https://reviews.llvm.org/rG21390eab4c05e0ed7e7d13ada9e85f62b87ea484) but as it seems, I should have added the differential division in the commit message. I'll try the next commit to be better. CHANGES SINCE LAST ACTION

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. In D74801#1898660 , @lattner wrote: > I'd be happy to help fix that problem. Please take a look at the llvm > developer policy. :-) Oh thanks, I thought I had to submit way more patches. CHANGES SINCE LAST ACTION

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lattner added a comment. I'd be happy to help fix that problem. Please take a look at the llvm developer policy. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. In D74801#1897267 , @lattner wrote: > Seems fine to me. Thank you! Please note that I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lattner accepted this revision. lattner added a comment. Seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. In D74801#1882155 , @lebedev.ri wrote: > lg Great! Just a note: I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri accepted this revision. lebedev.ri added a comment. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis updated this revision to Diff 245295. baziotis edited the summary of this revision. baziotis added a comment. Self-cycle to self-loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 Files:

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis marked an inline comment as done. baziotis added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1 && SCCI.hasCycle()) + errs() << "

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis marked an inline comment as done. baziotis added a comment. In D74801#1881693 , @lebedev.ri wrote: > While i certainly agree that it's kinda confusing, i'm not really sure this > is conceptually correct change. >

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1 && SCCI.hasCycle()) + errs() << "

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a subscriber: jdoerfert. baziotis added a comment. In D74801#1881679 , @efriedma wrote: > Seems fine. Great, thanks and to @jdoerfert! Any way I can find the correct reviewers next time? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added a comment. While i certainly agree that it's kinda confusing, i'm not really sure this is conceptually correct change. https://en.wikipedia.org/wiki/Loop_(graph_theory) > In graph theory, a loop (also called a self-loop or a "buckle") is an edge > that connects a vertex to

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801