[PATCH] D75107: [clang-tidy] hicpp-signed-bitwise IgnorePositiveIntegerLiterals now partially recursive

2020-09-13 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. ping. @njames93 are you revisiting this patch? What is the missing piece? Maybe i can help out a bit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75107/new/ https://reviews.llvm.org/D75107

[PATCH] D75107: [clang-tidy] hicpp-signed-bitwise IgnorePositiveIntegerLiterals now partially recursive

2020-02-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. What about bit shifting operations? e.g., `~(1 << 2)` or `8 >> (1 << 2)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75107/new/ https://reviews.llvm.org/D75107 ___

[PATCH] D75107: [clang-tidy] hicpp-signed-bitwise IgnorePositiveIntegerLiterals now partially recursive

2020-02-25 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh, hokein, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Addresses hicpp-signed-bitwise.IgnorePositiveIntegerLiterals should be recursive.