kadircet added a comment.
Thanks for working on this!
A few comments on macro handling and coding style. Apart from that mostly needs
more testing.
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:216
+ // Remove the virtual, override and final specifie
njames93 updated this revision to Diff 247538.
njames93 added a comment.
- Fix assertion when no Attrs are present
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75429/new/
https://reviews.llvm.org/D75429
Files:
clang-tools-extra/clangd/refactor/
njames93 updated this revision to Diff 247535.
njames93 added a comment.
- Made the replacements macro safe
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75429/new/
https://reviews.llvm.org/D75429
Files:
clang-tools-extra/clangd/refactor/tweaks/
njames93 updated this revision to Diff 247533.
njames93 added a comment.
- Extend to add virtual and final support
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75429/new/
https://reviews.llvm.org/D75429
Files:
clang-tools-extra/clangd/refactor/
njames93 created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
njames93 edited the summary of this revision.
njames93 added a project: clang-tools-extra.
The define out of line refactor tool pre
