[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

alexfh added a comment. In D75441#1901071 , @gribozavr2 wrote: > > I think my preference is to go with isLanguageVersionSupported() and not > > use base classes. > > +1, I can see this working, but the introduction of new concepts does not > seem like

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

njames93 marked an inline comment as done. njames93 added a comment. I suppose the only other way would be having another virtual function like inside the helper classes virtual bool additionalLanguageConstraints(const LangOptions& LangOpts) const { return true; } bool

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

gribozavr2 added a comment. > I think my preference is to go with isLanguageVersionSupported() and not use > base classes. +1, I can see this working, but the introduction of new concepts does not seem like it pulls its weight given the tiny amount of boilerplate that they eliminate.

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:210 + using ClangTidyCheck::ClangTidyCheck; + bool isLanguageVersionSupported(const LangOptions ) const final { +return LangOpts.C99; The `final` means that one

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:224 +/// Helper class for clang-tidy checks that only register when in `c++11` mode. +class Cpp11ClangTidyCheck : public ClangTidyCheck { + using

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh, lebedev.ri, Eugene.Zelenko. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75441 Files: