[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3f8913d2ad: Fix crash on XCore on unused inline in EmitTargetMetadata (authored by nigelp-xmos, committed by erichkeane). Changed prior to commit: https://reviews.llvm.org/D77068?vs=273100=273138#toc

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I talked to others about the test, and they suggested the correct way to validate this is to make it simply a 'doesn't crash' test, so I'll remove the filecheck/check lines and submit

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Nigel Perks via Phabricator via cfe-commits
nigelp-xmos added a comment. I do not have commit access, so if this is approved, please could it be committed against author "Nigel Perks" nig...@xmos.com ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Nigel Perks via Phabricator via cfe-commits
nigelp-xmos updated this revision to Diff 273100. nigelp-xmos retitled this revision from "[XCore] fix crash on unused inline in EmitTargetMetadata" to "Fix crash on XCore on unused inline in EmitTargetMetadata". nigelp-xmos added a comment. Added explanatory comment and CHECK lines to test