[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG55efb68c19b4: [MS] Mark vbase dtors used when marking dtor used (authored by rnk). Changed prior to commit:

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. I'm going to go ahead and push this today. Richard hasn't stamped it, but I did incorporate the feedback, and I'm fairly happy with the results and confident that I addressed the feedback adquately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. ptal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk updated this revision to Diff 253972. rnk added a comment. - finish refactoring, build & test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 Files: clang/include/clang/Sema/Sema.h

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. I'm glad to report that your suggestion worked out well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 ___ cfe-commits mailing list

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk updated this revision to Diff 253933. rnk added a comment. - Remove definition data bit tracking, use destructor isUsed bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 Files:

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16008-16013 +// In the MS ABI, the complete destructor is implicitly defined, +// even if the base destructor is user defined. +

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk marked 2 inline comments as done. rnk added a comment. Thanks for the feedback, I'm going to investigate if we can use the `used` destructor bit to do this. Comment at: clang/include/clang/AST/DeclCXX.h:959-963 + /// Indicates if the complete destructor has been

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:959-963 + /// Indicates if the complete destructor has been implicitly declared + /// yet. Only relevant in the Microsoft C++. + bool definedImplicitCompleteDestructor() const { +return

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. PTAL, here's how I imagine this is supposed to look, but the definition data bit name could probably be improved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk updated this revision to Diff 253715. rnk added a comment. - add def data bit - add tests - fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 Files:

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. DONOTSUBMIT: Uploading for feedback on approach, still have test failures: Failing Tests (1): Clang :: CXX/class.access/p4.cpp In the MS C++ ABI, complete destructors for classes