[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

2020-04-06 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1e4a8218b7: [analyzer] Fix NSErrorChecker false positives on constructors. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D77551?vs=255337=255407#toc Repository: rG

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

2020-04-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \ +// RUN: -analyzer-store=region -verify %s + vsavchenko wrote: > Szelethus wrote: > > NoQ

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

2020-04-06 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added a comment. In D77551#1964441 , @NoQ wrote: > Looks great, thanks! Do you already have commit access or should i commit > this for you? Thanks :-) No, I don't have commit access

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

2020-04-06 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \ +// RUN: -analyzer-store=region -verify %s + NoQ wrote: > `-analyzer-store=region` is

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

2020-04-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Do you already have commit access or should i commit this for you? Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

2020-04-06 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. NSErrorChecker