[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGa80afc032859: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGa80afc032859: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 ___ cfe-commits mailing list

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson added a comment. @MaskRay are you okay with me committing this change and delaying the global search-replace? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

spatel added a comment. In D78478#2128631 , @xbolva00 wrote: > >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). > > Me too. Any suggestions for new name? TCU_ARGS? I also reflexively think of universal time when reading "UTC".

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert added a comment. In D78478#2128926 , @arichardson wrote: > In D78478#2128604 , @MaskRay wrote: > > > The idea look good to me, but I want some opinions on the name `UTC_ARGS` > > (I can't help

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson added a comment. In D78478#2128604 , @MaskRay wrote: > The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I > can't help associating it with Coordinated Universal Time). Adding some folks > who may have opinions:

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

xbolva00 added a comment. >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). Me too. Any suggestions for new name? TCU_ARGS? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

MaskRay added subscribers: xbolva00, greened, spatel, lebedev.ri. MaskRay added a comment. The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I can't help associating it with Coordinated Universal Time). Adding some folks who may have opinions: @greened @lebedev.ri

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nice cleanup again! I think eventually we need to teach the common logic to recognize top-level entities, e.g., functions, and with these changes it will be accessible w/o duplication

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson updated this revision to Diff 274427. arichardson added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson updated this revision to Diff 259210. arichardson added a comment. Split into multiple reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 Files:

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson added a comment. In D78478#1994923 , @jdoerfert wrote: > I feel there is a lot of good stuff here but it seems to mix two things. A > rewrite of the script infrastructure and the UTC_ARGS stuff. If so, do you > think we could split them? I

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert added a comment. I feel there is a lot of good stuff here but it seems to mix two things. A rewrite of the script infrastructure and the UTC_ARGS stuff. If so, do you think we could split them? I feel there are also minor NFC changes that could go in on their own without review, I

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson created this revision. arichardson added reviewers: jdoerfert, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D69701 added support for on-the-fly argument changes for update scripts. I recently wanted to keep some manual check