[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279987 , @MaskRay wrote: > Several previous comments are FreeBSD specific. To we clang developers, the > concrete request is > >> Given that GCC will inline at -O, at least these days, ... > > right? I think this makes

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay added a comment. Several previous comments are FreeBSD specific. To we clang developers, the concrete request is > Given that GCC will inline at -O, at least these days, ... right? I think this makes sense, especially when `inline` is explicitly specified... This appears to be related

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279918 , @jrtc27 wrote: > In D79916#2279901 , @Bdragon28 wrote: > >> In D79916#2279884 , @jrtc27 wrote: >> >>> But also you really

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279901 , @Bdragon28 wrote: > In D79916#2279884 , @jrtc27 wrote: > >> But also you really should not get warnings for unused static functions in >> included headers, only ones

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279884 , @jrtc27 wrote: > But also you really should not get warnings for unused static functions in > included headers, only ones defined in the C source file itself. We'd have > countless warnings in the kernel

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279875 , @jrtc27 wrote: > In D79916#2279871 , @Bdragon28 wrote: > >> In D79916#2279866 , @jrtc27 wrote: >> >>> In D79916#2279863

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279871 , @Bdragon28 wrote: > In D79916#2279866 , @jrtc27 wrote: > >> In D79916#2279863 , @Bdragon28 >> wrote: >> >>> In D79916#2279816

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. (and FreeBSD has an `__always_inline` in sys/sys/cdef.s like `__inline`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79916/new/ https://reviews.llvm.org/D79916 ___ cfe-commits

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279866 , @jrtc27 wrote: > In D79916#2279863 , @Bdragon28 wrote: > >> In D79916#2279816 , @jrtc27 wrote: >> >>> In D79916#2279812

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279816 , @jrtc27 wrote: > In D79916#2279812 , @Bdragon28 wrote: > >> In D79916#2279045 , @jrtc27 wrote: >> >>> This has significantly

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279812 , @Bdragon28 wrote: > In D79916#2279045 , @jrtc27 wrote: > >> This has significantly regressed FreeBSD's performance with the new version >> of Clang. It seems Clang does

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279045 , @jrtc27 wrote: > This has significantly regressed FreeBSD's performance with the new version > of Clang. It seems Clang does not inline functions at -O1, unlike GCC, and > since FreeBSD currently compiles

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added subscribers: trasz, dim, jrtc27. jrtc27 added a comment. Herald added a subscriber: dang. This has significantly regressed FreeBSD's performance with the new version of Clang. It seems Clang does not inline functions at -O1, unlike GCC, and since FreeBSD currently compiles its

[PATCH] D79916: Map -O to -O1 instead of -O2

This revision was automatically updated to reflect the committed changes. Closed by commit rG82904401e327: Map -O to -O1 instead of -O2 (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D79916?vs=264029=264749#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay added a comment. In D79916#2042782 , @dexonsmith wrote: > In D79916#2039842 , @dexonsmith > wrote: > > > IOW, this LGTM if Alex and Gerolf are happy. > > > Gerolf told me he has no concerns. Thanks! (I

[PATCH] D79916: Map -O to -O1 instead of -O2

arphaman accepted this revision. arphaman added a comment. In D79916#2039842 , @dexonsmith wrote: > IOW, this LGTM if Alex and Gerolf are happy. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79916: Map -O to -O1 instead of -O2

dexonsmith added a comment. In D79916#2039842 , @dexonsmith wrote: > IOW, this LGTM if Alex and Gerolf are happy. Gerolf told me he has no concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79916: Map -O to -O1 instead of -O2

dexonsmith added reviewers: arphaman, Gerolf. dexonsmith accepted this revision. dexonsmith added a comment. IOW, this LGTM if Alex and Gerolf are happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79916/new/ https://reviews.llvm.org/D79916

[PATCH] D79916: Map -O to -O1 instead of -O2

dexonsmith added subscribers: arphaman, Gerolf. dexonsmith added a comment. In D79916#2039789 , @echristo wrote: > I'm totally down, but you knew that already :) > > Duncan: Do you have any concerns? I doubt it, but just checking. Xcode doesn't use

[PATCH] D79916: Map -O to -O1 instead of -O2

echristo accepted this revision. echristo added a reviewer: dexonsmith. echristo added a comment. This revision is now accepted and ready to land. I'm totally down, but you knew that already :) Duncan: Do you have any concerns? I doubt it, but just checking. Repository: rG LLVM Github

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay updated this revision to Diff 264029. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: dexonsmith, steven_wu, hiraditya. Update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79916: Map -O to -O1 instead of -O2

hans added a reviewer: echristo. hans added a comment. Actually it was http://llvm.org/r82131 that mapped -O to -O2 (I just refactored it). Originally it seems it was mapped to -O1. Because this seems to have done quite intentionally, I'm a little vary of changing it back. I'm not sure who

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay created this revision. MaskRay added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added a child revision: D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og. rL187583 mapped