[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6326b098852b: [AST][RecoveryExpr] Preserve type for broken overrload member call expr. (authored by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein updated this revision to Diff 311148. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80109/new/ https://reviews.llvm.org/D80109 Files: clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dump-recovery.cpp

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein marked 2 inline comments as done. hokein added a comment. sorry for the delay, picking it up now. Comment at: clang/lib/Sema/SemaCoroutine.cpp:864 ExprResult R = buildPromiseCall(*this, Promise, Loc, "await_transform", E); -if (R.isInvalid()) { +if

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein updated this revision to Diff 308267. hokein added a comment. Herald added a subscriber: lxfind. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80109/new/ https://reviews.llvm.org/D80109 Files:

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

sammccall added a comment. @hokein Did this get landed at some point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80109/new/ https://reviews.llvm.org/D80109 ___ cfe-commits mailing list

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:14083 OverloadCandidateSet::iterator Best; +bool Succeeded = true; switch

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14105 case OR_No_Viable_Function: CandidateSet.NoteCandidates( It is a bit sad that the broken function call cases (too many/few

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80109 Files: clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dump-recovery.cpp Index: clang/test/AST/ast-dump-recovery.cpp