This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ac737e56bee: [HeaderSearch] Fix processing #import-ed
headers multiple times with modules… (authored by vsapsai).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
vsapsai added a comment.
Thanks for the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Nice catch! LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
vsapsai added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai updated this revision to Diff 282035.
vsapsai added a comment.
Rebased the change to make sure it still works.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
Files:
vsapsai added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai added a comment.
Ping.
Also suggested clang-format linter changes make the test useless as the order
of imports is important.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80263/new/
https://reviews.llvm.org/D80263
vsapsai created this revision.
vsapsai added reviewers: rsmith, bruno, Bigcheese.
Herald added subscribers: ributzka, dexonsmith, jkorous.
Herald added a project: clang.
HeaderSearch was marking requested HeaderFileInfo as Resolved only based on
the presence of ExternalSource. As the result,
11 matches
Mail list logo