[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG48acac362938: [WebAssembly] Warn on exception spec only when Wasm EH is used (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin updated this revision to Diff 265645. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/was

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Derek Schuff via Phabricator via cfe-commits
dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. otherwise LGTM Comment at: clang/docs/DiagnosticsReference.rst:14018 ++-

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-20 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin updated this revision to Diff 265432. aheejin added a comment. - Fix warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/docs/DiagnosticsReference.rst clang/include/clan

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-20 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In D80061 we added warning for exception specifications with types (such as `throw(int)`), b