[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 updated this revision to Diff 265923. njames93 added a comment. - Added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80371/new/ https://reviews.llvm.org/D80371 Files:

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5818dd8cd9: [clang-tidy] Fix potential assert in use-noexcept check (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D80371?vs=265923=265924#toc Repository: rG LLVM Github

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

aaron.ballman added a comment. In D80371#2052454 , @njames93 wrote: > In D80371#2052069 , @aaron.ballman > wrote: > > > LGTM, but please add a test case for the changes. > > > As this fix is preventing a crash in

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 added a comment. In D80371#2052069 , @aaron.ballman wrote: > LGTM, but please add a test case for the changes. As this fix is preventing a crash in error causing code I can't include a specific test case as the clang-tidy tests will fail if

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 updated this revision to Diff 265899. njames93 added a comment. - Isolated exact cause of the assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80371/new/ https://reviews.llvm.org/D80371 Files:

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a test case for the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80371/new/

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 added a comment. Figured out the actual cause of this bug, `getExceptionSpecRange()` returns a null range if the function has an unknown return type undefined_type throws() throw(); This is the tidy output (where assertions are disabled) warning: dynamic exception specification

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fix a potential assert in use-noexcept check if there is an issue getting the `TypeSourceInfo` as well as a small clean