[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

MaskRay added a comment. Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p &&

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

This revision was automatically updated to reflect the committed changes. Closed by commit rG90b54fa045e3: [OPENMP50]Codegen for use_device_addr clauses. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D80730?vs=269618=270131#toc Repository: rG LLVM Github Monorepo

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18508 + // Component = CreateBuiltinUnaryOp(ELoc, UO_Deref, Component).get(); + // Component = DefaultFunctionArrayLvalueConversion(Component).get(); +

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. One nit below, the others seem silent. LGTM. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18508 + // Component = CreateBuiltinUnaryOp(ELoc, UO_Deref,

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 269618. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 268587. ABataev added a comment. Rebase and fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert added a subscriber: RaviNarayanaswamy. jdoerfert added a comment. I was hoping @dreachem and maybe @RaviNarayanaswamy would look at this. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630 +// OMPC_MAP_MODIFIER_last is used to identify data members used

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 268299. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert added reviewers: kkwli0, dreachem. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630 +// OMPC_MAP_MODIFIER_last is used to identify data members used in +// used_device_adddr clause. +bool

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 268219. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for use_device_addr clause. The components of the list items are mapped as a kind of RETURN components and then the returned base