[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-08-06 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song abandoned this revision. yonghong-song added a comment. inline asm can do the work, so abandon this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81479/new/ https://reviews.llvm.org/D81479

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-10 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. I guess I will go with inline asm in kernel for now as llvm seems already doing a pretty good job parsing/understanding inline asm to integrated into optimization passes. A few passes like SimplifyCFG, GVN, etc. may have some impact but probably does not really

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. In D81479#2083933 , @ast wrote: > It feels that the same thing can be represented as inline asm. > What advantage builtin has? Yes, this can be represented as an inline asm. I have a tendency not liking inline assembly

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-09 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added a comment. It feels that the same thing can be represented as inline asm. What advantage builtin has? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81479/new/ https://reviews.llvm.org/D81479

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

2020-06-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 269721. yonghong-song retitled this revision from "[BPF] introduce __builtin_load_u32_to_ptr() intrinsic" to "[BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic". yonghong-song edited the summary of this revision. yonghong-song added a comment.