This revision was automatically updated to reflect the committed changes.
Closed by commit rGd5fc592b7c26: [AArch64][SVE] Add bfloat16 support to svext
intrinsic (authored by c-rhodes).
Changed prior to commit:
https://reviews.llvm.org/D82391?vs=273685=274052#toc
Repository:
rG LLVM Github
sdesmalen accepted this revision.
sdesmalen added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82391/new/
https://reviews.llvm.org/D82391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
c-rhodes updated this revision to Diff 273685.
c-rhodes added a comment.
Changes:
- Add tests for bfloat bitcast patterns.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82391/new/
https://reviews.llvm.org/D82391
Files:
clang/include/clang/Basic/arm_sve.td
sdesmalen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1479
+ let Predicates = [IsLE, HasBF16] in {
+def : Pat<(nxv16i8 (bitconvert (nxv8bf16 ZPR:$src))), (nxv16i8 ZPR:$src)>;
+
These patterns are missing tests in
fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82391/new/
https://reviews.llvm.org/D82391
___
cfe-commits
c-rhodes updated this revision to Diff 273365.
c-rhodes added a comment.
Changes:
- Guard patterns on `+bf16`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82391/new/
https://reviews.llvm.org/D82391
Files:
clang/include/clang/Basic/arm_sve.td
fpetrogalli requested changes to this revision.
fpetrogalli added a comment.
This revision now requires changes to proceed.
Putting it on hold as we need to guard those patterns with `HasBF16`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82391/new/
https://reviews.llvm.org/D82391
c-rhodes created this revision.
c-rhodes added reviewers: sdesmalen, kmclaughlin, efriedma, david-arm,
fpetrogalli.
Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya,
kristof.beyls, tschuett.
Herald added projects: clang, LLVM.
Repository:
rG LLVM Github Monorepo
