This revision was automatically updated to reflect the committed changes.
Closed by commit rG5b9ce07a761f: [openmp] Use Directive_enumSize instead of
OMPD_unknown position (authored by clementval).
Changed prior to commit:
https://reviews.llvm.org/D82518?vs=273216=273327#toc
Repository:
rG
clementval marked 2 inline comments as done.
clementval added inline comments.
Comment at: clang/lib/Basic/OpenMPKinds.cpp:583
OpenMPDirectiveKind DKind) {
- assert(DKind <= OMPD_unknown);
+ assert(unsigned(DKind) <= llvm::omp::Directive_enumSize);
switch (DKind) {
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM, maybe a minor adjustment necessary.
Comment at: clang/lib/Basic/OpenMPKinds.cpp:583
OpenMPDirectiveKind DKind) {
- assert(DKind <= OMPD_unknown);
+
clementval updated this revision to Diff 273216.
clementval added a comment.
add unsigned cast
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82518/new/
https://reviews.llvm.org/D82518
Files:
clang/lib/Basic/OpenMPKinds.cpp
clementval created this revision.
clementval added reviewers: vdmitrie, jdoerfert, jdenny.
Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl.
Herald added a project: clang.
Previously OMPD_unknown was last item in the Directive enumeration and its
position was
used in various
