[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-07-01 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGf12cd99c440a: [clangd] Config: compile Fragment - CompiledFragment - Config (authored by sammccall). Changed prior to commit:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-07-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 8 inline comments as done. sammccall added a comment. Thanks a lot for the review, I think this is a lot better now. And particularly on where docs are lacking - I'm happy to write comments but it's hard for me to know which bits are least clear. Comment at:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-07-01 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + hokein wrote: > sammccall wrote: > > hokein wrote: > > > I think

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 274623. sammccall marked 13 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + sammccall wrote: > hokein wrote: > > I think if this case happened,

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 274503. sammccall added a comment. CompiledFragment becomes a std::function, compile interface moved to Fragment.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.h:47 + /// This always produces a usable compiled fragment (errors are recovered). + explicit CompiledFragment(Fragment, DiagnosticCallback); +

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 274470. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 8 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp hokein wrote: > sammccall wrote: > > hokein wrote: > > > we have a few

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp sammccall wrote: > hokein wrote: > > we have a few config-related files now, I wonder would it make sense to > >

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 10 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp hokein wrote: > we have a few config-related files now, I wonder would

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 274237. sammccall marked 3 inline comments as done. sammccall added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp we have a few config-related files now, I wonder would it make sense to create a config/ subdir?

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

2020-06-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. sammccall added a parent revision: D82606: [clangd] Config: config struct propagated through Context. sammccall edited