This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGffa63dde8e97: [clangd] Run formatting operations
asynchronously. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
sammccall marked 4 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:900
+ llvm::Expected Result) mutable {
+if (Result)
+ Reply(replacementsToEdits(Code, Result.get()));
k
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Looks nice just a couple of nits.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:900
+ llvm::Expected Result) mutable {
+if (Result)
+
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
They don't need ASTs or anything, so they should still run immediately.
These were sync for