hubert.reinterpretcast added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1006
"vexpandbm $vD, $vB", IIC_VecGeneral,
- []>;
+ [(set v16i8:$vD,
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGefa57f9a7adb: [PowerPC] Implement Vector Expand Mask
builtins in LLVM/Clang (authored by amyk).
Changed prior to commit:
Conanap accepted this revision.
Conanap added a comment.
This revision is now accepted and ready to land.
Minor nit, okay if changed for commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82727/new/
https://reviews.llvm.org/D82727
Conanap added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:993
+ [(set v16i8:$vD,
(int_ppc_altivec_vexpandbm
+ v16i8:$vB))]>;
def VEXPANDHM : VXForm_RD5_XO5_RS5<1602, 1,
amyk updated this revision to Diff 287434.
amyk added a comment.
Update clang test names for `vec_expandm`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82727/new/
https://reviews.llvm.org/D82727
Files:
NeHuang added a comment.
Overall LGTM. I only have some nits comment.
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:136
+vector unsigned char test_vexpandm_uc(void) {
+ // CHECK: @llvm.ppc.altivec.vexpandbm(<16 x i8> %{{.+}})
nit: can we change
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:881
+ [(set v16i8:$vD,
(int_ppc_altivec_vexpandbm
+ v16i8:$vB))]>;
def VEXPANDHM : VXForm_RD5_XO5_RS5<1602, 1, (outs
amyk updated this revision to Diff 283065.
amyk added a comment.
Rebased the patch and removed MC tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82727/new/
https://reviews.llvm.org/D82727
Files:
clang/include/clang/Basic/BuiltinsPPC.def
