[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

This revision was automatically updated to reflect the committed changes. Closed by commit rGa06a5ed97800: [clang-tidy] Added option to readability-else-after-return (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82824?vs=274473=274569#toc Repository: rG LLVM

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM once the documentation nit is fixed up. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return;

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return; njames93 wrote: > aaron.ballman

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return;

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return; Would it make sense to hoist this

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 updated this revision to Diff 274473. njames93 added a comment. Renamed new option to WarnOnConditionVariables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82824/new/ https://reviews.llvm.org/D82824 Files:

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:74 + + When `true`, The check will attempt to refactor a variable defined inside + the condition of the ``if`` statement that is used in the ``else``

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:74 + + When `true`, The check will attempt to refactor a variable defined inside + the condition of the ``if``

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:67 + + When `true`, Emit a warning for cases where the check can't output a + Fix-It. These can occur with declarations inside the ``else`` branch

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 updated this revision to Diff 274353. njames93 added a comment. Address doc backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82824/new/ https://reviews.llvm.org/D82824 Files:

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:200 + ` check now supports a + ``RefactorConditionVariables`` option to control whether to refactor condition + variables where possible. Please use single back-ticks

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Added a 'RefactorConditionVariables' option to control how the check handles condition variables Repository: rG LLVM