[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3c693b617f: [clang-tidy] Added alias llvm-else-after-return. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3c693b617f: [clang-tidy] Added alias llvm-else-after-return. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. In D82825#2123186 , @aaron.ballman wrote: > I can see arguments either way on this. Personally, I would not want the > check to diagnose this code because that would encourage people to widen the > scope and lifetime of `X` or

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman added a comment. In D82825#2123125 , @njames93 wrote: > In D82825#2122789 , @aaron.ballman > wrote: > > > Other than the documentation and settling on the option name in the parent > > revision, I

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. In D82825#2122789 , @aaron.ballman wrote: > Other than the documentation and settling on the option name in the parent > revision, I think this LGTM (the changes will be mechanical and can be done > without further review once

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 updated this revision to Diff 274476. njames93 added a comment. Moved docs into target check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://reviews.llvm.org/D82825 Files:

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Other than the documentation and settling on the option name in the parent revision, I think this LGTM (the changes will be mechanical and can be done without further review

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:3 +.. meta:: + :http-equiv=refresh: 5;URL=readability-else-after-return.html + aaron.ballman wrote: >

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:3 +.. meta:: + :http-equiv=refresh: 5;URL=readability-else-after-return.html + Hmmm, this means users have five seconds to read the text below

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 updated this revision to Diff 274359. njames93 added a comment. Address doc backticks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://reviews.llvm.org/D82825 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:15 + +Note: In this alias the options ``WarnOnUnfixable`` and +``RefactorConditionVariables`` are both set to ``false`` by default. Please use

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 added a comment. This is supposed to have a parent revision D82824 but for some

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. This is supposed to have a parent revision D82824 but for some reason phab won't let me add it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://reviews.llvm.org/D82825