[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82986#2126479 , @thakis wrote: > That's not enough, you also need to add an rm to remove the stale .LL file > still on disk, see my comment on your original change. It's in https://reviews.llvm.org/D82992 if you could help

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGddcf063dd52f: [Coroutines] Fix test breakage in D82928 (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. lxfind added reviewers: modocache, fhahn. Herald added a project: clang. Herald added a subscriber: cfe-commits. modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! The test file in