This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf7160c0b0c1: [clangd] Config: also propagate in sync
(testing) mode (authored by sammccall).
Herald added a subscriber: jfb.
Changed prior to commit:
sammccall marked an inline comment as done.
sammccall added a comment.
Also added one direct test for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83802/new/
https://reviews.llvm.org/D83802
___
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1241
+ // Avoid null checks everywhere.
+ if (!Opts.ContextProvider)
+this->Opts.ContextProvider
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
javed.absar, ilya-biryukov.
Herald added a project: clang.
Tests are coming (really!).
I hit this while trying to add a config-over-LSP lit test,
