This revision was automatically updated to reflect the committed changes.
Closed by commit rGec6ada62643c: [AIX] report_fatal_error on
`-fregister_global_dtors_with_atexit` for static… (authored by Xiangling_L).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
LGTM; thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83974/new/
https://reviews.llvm.org/D83974
___
cfe-commits mailing list
Xiangling_L updated this revision to Diff 278777.
Xiangling_L marked 2 inline comments as done.
Xiangling_L added a comment.
Adjust the quesry;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83974/new/
https://reviews.llvm.org/D83974
Files:
clang/lib/CodeGen/CodeGenModule.cpp
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1212
if (CodeGenOpts.RegisterGlobalDtorsWithAtExit) {
+if (getContext().getTargetInfo().getTriple().isOSAIX())
+ llvm::report_fatal_error(
This should query
jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
LGTM with minor nit.
Comment at:
clang/test/CodeGenCXX/aix-sinit-register-global-dtors-with-atexit.cpp:10
+struct T{
+T();
+~T();
nit: fix
Xiangling_L created this revision.
Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, yusra.syeda.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
On AIX, the semantic of global_dtors contains `__sterm` functions associated
with C++ cleanup actions and
