[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2023-06-09 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm abandoned this revision. arsenm added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. This was already done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84068/new/ https://reviews.llvm.org/D84068 ___

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-08-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D84068#2210872 , @echristo wrote: > Hi All, > > I'd really like to avoid depending on any program other than clang installing > something into clang's working directory. I think this needs to be written > from the perspective

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-08-11 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. Hi All, I'd really like to avoid depending on any program other than clang installing something into clang's working directory. I think this needs to be written from the perspective of specifying another directory to look for things. -eric CHANGES SINCE LAST ACTION

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-08-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D84068#2208394 , @arsenm wrote: >> > > Long term, I'd rather aim for merging rocm-device-libs into libclc and making > it an llvm project. They're largely forks of the same original sources from > about 5 years ago, and it's

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-08-10 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D84068#2208132 , @tra wrote: > In D84068#2204713 , @arsenm wrote: > >>> If we ship them with clang, who/where/how builds them? >>> If they come from ROCm packages, how would those

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-08-10 Thread Artem Belevich via Phabricator via cfe-commits
tra added a subscriber: echristo. tra added a comment. In D84068#2204713 , @arsenm wrote: >> If we ship them with clang, who/where/how builds them? >> If they come from ROCm packages, how would those packages add stuff into >> *clang* install directory?

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-08-08 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D84068#2159391 , @tra wrote: > Could you walk me through how you see this working in practice? > > IIUIC, the idea is to have bitcode files located somewhere within clang > installation. Yes > If that's the case, will we ship

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-07-17 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Could you walk me through how you see this working in practice? IIUIC, the idea is to have bitcode files located somewhere within clang installation. If that's the case, will we ship those bitcode libraries with clang, or do they come from ROCm packages? If we ship them

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

2020-07-17 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: yaxunl, tra. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This should be the preferred way of locating the libraries, and it's a packaging problem to ensure the libraries are symlinked into the