[PATCH] D84987: Pass bugreport URL to standalone clang build

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Verified. I added `CMAKE_PREFIX_PATH` to my `/tmp/RelA/CMakeCache.txt` and 
invoked `ninja install` (this installed a bunch of unrelated files. I don't 
know know how to just install-cmake-exports and files it requires (.e.g 
LLVMDemangler.a)).

A standalone build of clang prints: `PLEASE submit a bug report to  and include 
the crash backtrace, preprocessed source , and associated run script.` running 
on a file with `#pragma clang __debug parser_crash`

This patch fixes it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84987/new/

https://reviews.llvm.org/D84987

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84987: Pass bugreport URL to standalone clang build

[Michał Górny via Phabricator via cfe-commits]

mgorny added a comment.

Is `RelA` an actual result of `install` target, or just the build tree? I think 
it needs to be the former.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84987/new/

https://reviews.llvm.org/D84987

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84987: Pass bugreport URL to standalone clang build

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D84987#2186639 , @mgorny wrote:

> In D84987#2186113 , @MaskRay wrote:
>
>> I am not familiar with the standalone clang build. Can you share a command?
>
> You install LLVM first, then run `cmake /clang` and build 
> it.

Can you elaborate? The so-called "standalone build" isn't documented anywhere. 
My llvm-config is in `/tmp/RelA/bin/llvm-config`. I run 
`PATH=/tmp/RelA/bin:$PATH cmake -GNinja -H/path/to//clang -BTest`, it fails:

  -- Performing Test CXX_SUPPORTS_NO_NESTED_ANON_TYPES_FLAG - Failed
  CMake Error at /tmp/RelA/lib/cmake/llvm/AddLLVM.cmake:823 (add_executable):
add_executable cannot create target "clang-tblgen" because an imported
target with the same name already exists.
  Call Stack (most recent call first):
/tmp/RelA/lib/cmake/llvm/TableGen.cmake:148 (add_llvm_executable)
utils/TableGen/CMakeLists.txt:3 (add_tablegen)
  
  
  CMake Error at /tmp/RelA/lib/cmake/llvm/LLVM-Config.cmake:105 
(target_link_libraries):
Cannot specify link libraries for target "clang-tblgen" which is not built
by this project.
  Call Stack (most recent call first):
/tmp/RelA/lib/cmake/llvm/LLVM-Config.cmake:93 (explicit_llvm_config)
/tmp/RelA/lib/cmake/llvm/AddLLVM.cmake:867 (llvm_config)
/tmp/RelA/lib/cmake/llvm/TableGen.cmake:148 (add_llvm_executable)
utils/TableGen/CMakeLists.txt:3 (add_tablegen)
  
  
  -- Configuring incomplete, errors occurred!
  See also "/tmp/c/Test/CMakeFiles/CMakeOutput.log".
  See also "/tmp/c/Test/CMakeFiles/CMakeError.log".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84987/new/

https://reviews.llvm.org/D84987

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84987: Pass bugreport URL to standalone clang build

[Michał Górny via Phabricator via cfe-commits]

mgorny added a comment.

In D84987#2186113 , @MaskRay wrote:

> I am not familiar with the standalone clang build. Can you share a command?

You install LLVM first, then run `cmake /clang` and build it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84987/new/

https://reviews.llvm.org/D84987

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84987: Pass bugreport URL to standalone clang build

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

I am not familiar with the standalone clang build. Can you share a command?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84987/new/

https://reviews.llvm.org/D84987

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84987: Pass bugreport URL to standalone clang build

[Michał Górny via Phabricator via cfe-commits]

mgorny created this revision.
mgorny added reviewers: john.brawn, MaskRay, chapuni.
Herald added a project: LLVM.
mgorny requested review of this revision.

BUG_REPORT_URL is currently used both in LLVM and in Clang but declared
only in the latter.  This means that it's missing in standalone clang
builds and the driver ends up outputting:

  PLEASE submit a bug report to and include [...]

(note the missing URL)

To fix this, include LLVM_PACKAGE_BUGREPORT in LLVMConfig.cmake
(similarly to how we pass PACKAGE_VERSION) and use it to fill
BUG_REPORT_URL when building clang standalone.


https://reviews.llvm.org/D84987

Files:
  clang/CMakeLists.txt
  llvm/cmake/modules/LLVMConfig.cmake.in


Index: llvm/cmake/modules/LLVMConfig.cmake.in
===
--- llvm/cmake/modules/LLVMConfig.cmake.in
+++ llvm/cmake/modules/LLVMConfig.cmake.in
@@ -7,6 +7,7 @@
 set(LLVM_VERSION_PATCH @LLVM_VERSION_PATCH@)
 set(LLVM_VERSION_SUFFIX @LLVM_VERSION_SUFFIX@)
 set(LLVM_PACKAGE_VERSION @PACKAGE_VERSION@)
+set(LLVM_PACKAGE_BUGREPORT @PACKAGE_BUGREPORT@)
 
 set(LLVM_BUILD_TYPE @CMAKE_BUILD_TYPE@)
 
Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -121,6 +121,8 @@
   include(LLVMDistributionSupport)
 
   set(PACKAGE_VERSION "${LLVM_PACKAGE_VERSION}")
+  set(BUG_REPORT_URL "${LLVM_PACKAGE_BUGREPORT}" CACHE STRING
+"Default URL where bug reports are to be submitted.")
 
   if (NOT DEFINED LLVM_INCLUDE_TESTS)
 set(LLVM_INCLUDE_TESTS ON)


Index: llvm/cmake/modules/LLVMConfig.cmake.in
===
--- llvm/cmake/modules/LLVMConfig.cmake.in
+++ llvm/cmake/modules/LLVMConfig.cmake.in
@@ -7,6 +7,7 @@
 set(LLVM_VERSION_PATCH @LLVM_VERSION_PATCH@)
 set(LLVM_VERSION_SUFFIX @LLVM_VERSION_SUFFIX@)
 set(LLVM_PACKAGE_VERSION @PACKAGE_VERSION@)
+set(LLVM_PACKAGE_BUGREPORT @PACKAGE_BUGREPORT@)
 
 set(LLVM_BUILD_TYPE @CMAKE_BUILD_TYPE@)
 
Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -121,6 +121,8 @@
   include(LLVMDistributionSupport)
 
   set(PACKAGE_VERSION "${LLVM_PACKAGE_VERSION}")
+  set(BUG_REPORT_URL "${LLVM_PACKAGE_BUGREPORT}" CACHE STRING
+"Default URL where bug reports are to be submitted.")
 
   if (NOT DEFINED LLVM_INCLUDE_TESTS)
 set(LLVM_INCLUDE_TESTS ON)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits