[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

This revision was automatically updated to reflect the committed changes. Closed by commit rG48b510c4bc0f: [NFC] Fix compiler warnings due to integer comparison of different signedness (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

RKSimon accepted this revision. RKSimon added a comment. LGTM - I'll try to commit this later today Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 ___

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290944. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 Files: clang/lib/Lex/Pragma.cpp llvm/lib/Analysis/VectorUtils.cpp llvm/lib/MC/WasmObjectWriter.cpp

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290886. nullptr.cpp added a comment. [NFC] Fix pessimizing-move warnings due to std::move in return statements Gcc warning: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp added a comment. I don't have commit access, can anyone help me commit this with `"Yang Fan "` ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290864. nullptr.cpp added a comment. Fix by directly using `INT_MAX` and `INT32_MAX`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 Files:

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Couldn't we avoid a lot of this of this casting + template ugliness by just using the / INT_MAX / INT32_MAX defines? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp added a comment. I don't have commit access, can anyone help commit this and D86997 ? Yang Fan Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, sbc100. Herald added projects: clang, LLVM. nullptr.cpp requested review of this revision. Herald added a subscriber: aheejin. Fix by explicitly expressing the conversions that caused by comparison.