[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291621. compnerd added a comment. - Add additional test case that was requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include/clang/Basic/Attr.td

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291587. compnerd added a comment. Add additional test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include/clang/Basic/Attr.td

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7543 + case ParsedAttr::AT_SwiftBridgedTypedef: +handleSimpleAttribute(S, D, AL); +break; compnerd wrote: > aaron.ballman wrote: > > compnerd wrote: > > > aaron.ballman

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7543 + case ParsedAttr::AT_SwiftBridgedTypedef: +handleSimpleAttribute(S, D, AL); +break; aaron.ballman wrote: > compnerd wrote: > >

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2123 + let Spellings = [GNU<"swift_bridged_typedef">]; + let Subjects = SubjectList<[TypedefName], ErrorDiag, "typedefs">; + let Documentation = [SwiftBridgedTypedefDocs];

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2123 + let Spellings = [GNU<"swift_bridged_typedef">]; + let Subjects = SubjectList<[TypedefName], ErrorDiag, "typedefs">; + let Documentation = [SwiftBridgedTypedefDocs];

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291346. compnerd edited the summary of this revision. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files:

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; aaron.ballman wrote: > Should this be inherited on redeclarations? I don't see why not.

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; Should this be inherited on redeclarations? Comment at:

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Extend the semantic attributes that clang processes for Swift to include `swift_typedef_bridged`. This