[PATCH] D87451: add new option -mignore-xcoff-visibility

dmgreen added a comment. Hello. I added a power-pc REQUIRES clause to the new clang test here in a15bd0bfc20c2b2955c59450a67b6e8efe89c708 . Hope that looks OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87451: add new option -mignore-xcoff-visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. DiggerLin marked an inline comment as done. Closed by commit rG92bca1284308: [AIX] add new option -mignore-xcoff-visibility (authored by DiggerLin). Changed prior to

[PATCH] D87451: add new option -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/include/llvm/Target/TargetOptions.h:126 FunctionSections(false), DataSections(false), - UniqueSectionNames(true), UniqueBasicBlockSectionNames(false), -

[PATCH] D87451: add new option -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: llvm/include/llvm/Target/TargetOptions.h:126 FunctionSections(false), DataSections(false), - UniqueSectionNames(true), UniqueBasicBlockSectionNames(false), - TrapUnreachable(false),

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, other minor nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file (XCOFF only) + nit: plural. capitalization.

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:339 + "ignore-xcoff-visibility", + cl::desc("Not emit the visibility attribute for asm in AIX OS or give " + "all symbols 'unspecified' visibility in xcoff object file"),