[PATCH] D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration

[Eduardo Caldas via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG87f0b51d68de: [SyntaxTree][NFC] follow naming convention + 
remove auto on empty vector… (authored by eduucaldas).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88004/new/

https://reviews.llvm.org/D88004

Files:
  clang/lib/Tooling/Syntax/BuildTree.cpp
  clang/lib/Tooling/Syntax/Nodes.cpp
  clang/lib/Tooling/Syntax/Tree.cpp

Index: clang/lib/Tooling/Syntax/Tree.cpp
===
--- clang/lib/Tooling/Syntax/Tree.cpp
+++ clang/lib/Tooling/Syntax/Tree.cpp
@@ -153,7 +153,7 @@
 
 static void dumpNode(raw_ostream , const syntax::Node *N,
  const SourceManager , std::vector IndentMask) {
-  auto dumpExtraInfo = [](const syntax::Node *N) {
+  auto DumpExtraInfo = [](const syntax::Node *N) {
 if (N->getRole() != syntax::NodeRole::Unknown)
   OS << " " << N->getRole();
 if (!N->isOriginal())
@@ -167,14 +167,14 @@
 OS << "'";
 dumpLeaf(OS, L, SM);
 OS << "'";
-dumpExtraInfo(N);
+DumpExtraInfo(N);
 OS << "\n";
 return;
   }
 
   const auto *T = cast(N);
   OS << T->getKind();
-  dumpExtraInfo(N);
+  DumpExtraInfo(N);
   OS << "\n";
 
   for (const auto *It = T->getFirstChild(); It; It = It->getNextSibling()) {
@@ -302,20 +302,20 @@
   if (!getFirstChild())
 return {};
 
-  auto children = std::vector>();
-  syntax::Node *elementWithoutDelimiter = nullptr;
+  std::vector> Children;
+  syntax::Node *ElementWithoutDelimiter = nullptr;
   for (auto *C = getFirstChild(); C; C = C->getNextSibling()) {
 switch (C->getRole()) {
 case syntax::NodeRole::ListElement: {
-  if (elementWithoutDelimiter) {
-children.push_back({elementWithoutDelimiter, nullptr});
+  if (ElementWithoutDelimiter) {
+Children.push_back({ElementWithoutDelimiter, nullptr});
   }
-  elementWithoutDelimiter = C;
+  ElementWithoutDelimiter = C;
   break;
 }
 case syntax::NodeRole::ListDelimiter: {
-  children.push_back({elementWithoutDelimiter, cast(C)});
-  elementWithoutDelimiter = nullptr;
+  Children.push_back({ElementWithoutDelimiter, cast(C)});
+  ElementWithoutDelimiter = nullptr;
   break;
 }
 default:
@@ -326,19 +326,19 @@
 
   switch (getTerminationKind()) {
   case syntax::List::TerminationKind::Separated: {
-children.push_back({elementWithoutDelimiter, nullptr});
+Children.push_back({ElementWithoutDelimiter, nullptr});
 break;
   }
   case syntax::List::TerminationKind::Terminated:
   case syntax::List::TerminationKind::MaybeTerminated: {
-if (elementWithoutDelimiter) {
-  children.push_back({elementWithoutDelimiter, nullptr});
+if (ElementWithoutDelimiter) {
+  Children.push_back({ElementWithoutDelimiter, nullptr});
 }
 break;
   }
   }
 
-  return children;
+  return Children;
 }
 
 // Almost the same implementation of `getElementsAsNodesAndDelimiters` but
@@ -347,20 +347,20 @@
   if (!getFirstChild())
 return {};
 
-  auto children = std::vector();
-  syntax::Node *elementWithoutDelimiter = nullptr;
+  std::vector Children;
+  syntax::Node *ElementWithoutDelimiter = nullptr;
   for (auto *C = getFirstChild(); C; C = C->getNextSibling()) {
 switch (C->getRole()) {
 case syntax::NodeRole::ListElement: {
-  if (elementWithoutDelimiter) {
-children.push_back(elementWithoutDelimiter);
+  if (ElementWithoutDelimiter) {
+Children.push_back(ElementWithoutDelimiter);
   }
-  elementWithoutDelimiter = C;
+  ElementWithoutDelimiter = C;
   break;
 }
 case syntax::NodeRole::ListDelimiter: {
-  children.push_back(elementWithoutDelimiter);
-  elementWithoutDelimiter = nullptr;
+  Children.push_back(ElementWithoutDelimiter);
+  ElementWithoutDelimiter = nullptr;
   break;
 }
 default:
@@ -370,19 +370,19 @@
 
   switch (getTerminationKind()) {
   case syntax::List::TerminationKind::Separated: {
-children.push_back(elementWithoutDelimiter);
+Children.push_back(ElementWithoutDelimiter);
 break;
   }
   case syntax::List::TerminationKind::Terminated:
   case syntax::List::TerminationKind::MaybeTerminated: {
-if (elementWithoutDelimiter) {
-  children.push_back(elementWithoutDelimiter);
+if (ElementWithoutDelimiter) {
+  Children.push_back(ElementWithoutDelimiter);
 }
 break;
   }
   }
 
-  return children;
+  return Children;
 }
 
 clang::tok::TokenKind syntax::List::getDelimiterTokenKind() const {
Index: clang/lib/Tooling/Syntax/Nodes.cpp
===
--- clang/lib/Tooling/Syntax/Nodes.cpp
+++ clang/lib/Tooling/Syntax/Nodes.cpp
@@ -226,23 +226,23 @@
 // vector
 std::vector
 syntax::NestedNameSpecifier::getSpecifiers() {
-  auto specifiersAsNodes = getElementsAsNodes();
+  auto SpecifiersAsNodes = 

[PATCH] D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration

[Eduardo Caldas via Phabricator via cfe-commits]

eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88004

Files:
  clang/lib/Tooling/Syntax/BuildTree.cpp
  clang/lib/Tooling/Syntax/Nodes.cpp
  clang/lib/Tooling/Syntax/Tree.cpp

Index: clang/lib/Tooling/Syntax/Tree.cpp
===
--- clang/lib/Tooling/Syntax/Tree.cpp
+++ clang/lib/Tooling/Syntax/Tree.cpp
@@ -153,7 +153,7 @@
 
 static void dumpNode(raw_ostream , const syntax::Node *N,
  const SourceManager , std::vector IndentMask) {
-  auto dumpExtraInfo = [](const syntax::Node *N) {
+  auto DumpExtraInfo = [](const syntax::Node *N) {
 if (N->getRole() != syntax::NodeRole::Unknown)
   OS << " " << N->getRole();
 if (!N->isOriginal())
@@ -167,14 +167,14 @@
 OS << "'";
 dumpLeaf(OS, L, SM);
 OS << "'";
-dumpExtraInfo(N);
+DumpExtraInfo(N);
 OS << "\n";
 return;
   }
 
   const auto *T = cast(N);
   OS << T->getKind();
-  dumpExtraInfo(N);
+  DumpExtraInfo(N);
   OS << "\n";
 
   for (const auto *It = T->getFirstChild(); It; It = It->getNextSibling()) {
@@ -302,20 +302,20 @@
   if (!getFirstChild())
 return {};
 
-  auto children = std::vector>();
-  syntax::Node *elementWithoutDelimiter = nullptr;
+  std::vector> Children;
+  syntax::Node *ElementWithoutDelimiter = nullptr;
   for (auto *C = getFirstChild(); C; C = C->getNextSibling()) {
 switch (C->getRole()) {
 case syntax::NodeRole::ListElement: {
-  if (elementWithoutDelimiter) {
-children.push_back({elementWithoutDelimiter, nullptr});
+  if (ElementWithoutDelimiter) {
+Children.push_back({ElementWithoutDelimiter, nullptr});
   }
-  elementWithoutDelimiter = C;
+  ElementWithoutDelimiter = C;
   break;
 }
 case syntax::NodeRole::ListDelimiter: {
-  children.push_back({elementWithoutDelimiter, cast(C)});
-  elementWithoutDelimiter = nullptr;
+  Children.push_back({ElementWithoutDelimiter, cast(C)});
+  ElementWithoutDelimiter = nullptr;
   break;
 }
 default:
@@ -326,19 +326,19 @@
 
   switch (getTerminationKind()) {
   case syntax::List::TerminationKind::Separated: {
-children.push_back({elementWithoutDelimiter, nullptr});
+Children.push_back({ElementWithoutDelimiter, nullptr});
 break;
   }
   case syntax::List::TerminationKind::Terminated:
   case syntax::List::TerminationKind::MaybeTerminated: {
-if (elementWithoutDelimiter) {
-  children.push_back({elementWithoutDelimiter, nullptr});
+if (ElementWithoutDelimiter) {
+  Children.push_back({ElementWithoutDelimiter, nullptr});
 }
 break;
   }
   }
 
-  return children;
+  return Children;
 }
 
 // Almost the same implementation of `getElementsAsNodesAndDelimiters` but
@@ -347,20 +347,20 @@
   if (!getFirstChild())
 return {};
 
-  auto children = std::vector();
-  syntax::Node *elementWithoutDelimiter = nullptr;
+  std::vector Children;
+  syntax::Node *ElementWithoutDelimiter = nullptr;
   for (auto *C = getFirstChild(); C; C = C->getNextSibling()) {
 switch (C->getRole()) {
 case syntax::NodeRole::ListElement: {
-  if (elementWithoutDelimiter) {
-children.push_back(elementWithoutDelimiter);
+  if (ElementWithoutDelimiter) {
+Children.push_back(ElementWithoutDelimiter);
   }
-  elementWithoutDelimiter = C;
+  ElementWithoutDelimiter = C;
   break;
 }
 case syntax::NodeRole::ListDelimiter: {
-  children.push_back(elementWithoutDelimiter);
-  elementWithoutDelimiter = nullptr;
+  Children.push_back(ElementWithoutDelimiter);
+  ElementWithoutDelimiter = nullptr;
   break;
 }
 default:
@@ -370,19 +370,19 @@
 
   switch (getTerminationKind()) {
   case syntax::List::TerminationKind::Separated: {
-children.push_back(elementWithoutDelimiter);
+Children.push_back(ElementWithoutDelimiter);
 break;
   }
   case syntax::List::TerminationKind::Terminated:
   case syntax::List::TerminationKind::MaybeTerminated: {
-if (elementWithoutDelimiter) {
-  children.push_back(elementWithoutDelimiter);
+if (ElementWithoutDelimiter) {
+  Children.push_back(ElementWithoutDelimiter);
 }
 break;
   }
   }
 
-  return children;
+  return Children;
 }
 
 clang::tok::TokenKind syntax::List::getDelimiterTokenKind() const {
Index: clang/lib/Tooling/Syntax/Nodes.cpp
===
--- clang/lib/Tooling/Syntax/Nodes.cpp
+++ clang/lib/Tooling/Syntax/Nodes.cpp
@@ -226,23 +226,23 @@
 // vector
 std::vector
 syntax::NestedNameSpecifier::getSpecifiers() {
-  auto specifiersAsNodes = getElementsAsNodes();
+  auto SpecifiersAsNodes = getElementsAsNodes();
   std::vector Children;
-  for (const auto  : specifiersAsNodes) {
-Children.push_back(llvm::cast(element));
+