[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2314415 , @hans wrote: > I've committed this as 66e4f07198761bbb4dcd55235024c1081ed15c75 > so it > has a chance to make it into the 11.0.0 release.

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. I've committed this as 66e4f07198761bbb4dcd55235024c1081ed15c75 so it has a chance to make it into the 11.0.0 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e4f0719876: Add ability to turn off -fpch-instantiate-templates in clang-cl (authored by shivanshu3, committed by hans). Repository: rG LLVM

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 updated this revision to Diff 296393. shivanshu3 added a comment. Address Hans' comments - Prepend %s with "--" for clang-cl - Remove a redundant test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added inline comments. Comment at: clang/test/Driver/pch-instantiate-templates.c:2 +// CL driver test cases +// RUN: %clang_cl -### /Yc /Fpfoo.pch /Fofoo.obj %s 2>&1 | FileCheck --check-prefix=CLANG_CL_YC %s +// RUN: %clang -### --driver-mode=cl /Yc /Fpfoo.pch /Fofoo.obj

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

llunak added a comment. LGTM, although I'm not sure if me saying that is enough. I'll commit this in few days if nobody says anything else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/ https://reviews.llvm.org/D88680

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 updated this revision to Diff 296340. shivanshu3 added a comment. Address Reid's comments: - Use hasFlag instead of hasArg - Add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/ https://reviews.llvm.org/D88680

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2308601 , @zahen wrote: > This patch doesn't need a test case outside of the one that @rnk requested to > make sure that the flag flows from the clang-cl driver appropriately. > `pch-instantiate-templates` as authored

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

zahen added a comment. This patch doesn't need a test case outside of the one that @rnk requested to make sure that the flag flows from the clang-cl driver appropriately. `pch-instantiate-templates` as authored doesn't match cl.exe behavior and being unable to turn it off will prevent our

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. Also, I wanted to mention that clang-cl.exe actually crashes deterministically when running precompiles for 2 of our headers when using '-fpch-instantiate-templates' with the following signature: 1. parser at end of file 2. Per-file LLVM IR generation

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. > Can you get at least some testcase, even if not small? Yes, in a few days I can get you the test case. I'll have to figure out what our company policy is for sharing code and if I should obfuscate it so I don't get into trouble :) > MSVC does some kind of

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

llunak added a comment. > I tried pretty hard to get a small repro for these failures, but couldn't. Can you get at least some testcase, even if not small? You can use -E -frewrite-includes to create a single large file from all the input. Although the patch looks fine to me as such, I

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. In D88680#2307564 , @rnk wrote: > I think the flag was originally intended to be an internal -cc1 flag not > exposed to users. You should be able to work around your problem with > `-Xclang -fno-pch-instantiate-templates`,

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

rnk added a subscriber: zequanwu. rnk added a comment. I think the flag was originally intended to be an internal -cc1 flag not exposed to users. You should be able to work around your problem with `-Xclang -fno-pch-instantiate-templates`, btw. @zequanwu, can you patch this in locally

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Please use the following commit author details: "Shivan Goyal " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 created this revision. shivanshu3 added reviewers: llunak, rnk, rsmith, hans, zahen. shivanshu3 added a project: clang. Herald added subscribers: cfe-commits, dang. shivanshu3 requested review of this revision. A lot of our code building with clang-cl.exe using Clang 11 was failing