This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1425c7223676: [clangd] Add isKeyword function. (authored by
hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:638
+ // Keywords are initialized in constructor.
+ clang::IdentifierTable KeywordsTable(LangOpts);
+ return KeywordsTable.find(NewName) != KeywordsTable.end();
sammccall wrote:
hokein updated this revision to Diff 296168.
hokein marked an inline comment as done.
hokein added a comment.
address code comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88810/new/
https://reviews.llvm.org/D88810
Files:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:638
+ // Keywords are initialized in constructor.
+ clang::IdentifierTable KeywordsTable(LangOpts);
+ return
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: clang.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This will be used in rename for doing basic name
