[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:557 // :-( llvm::SmallString<256> QName; for (const auto : IncludeFiles) kadircet wrote: > this one is no longer needed. whoops, fixed in

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:557 // :-( llvm::SmallString<256> QName; for (const auto : IncludeFiles) this one is no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69daa368cad3: [clangd] Disambiguate overloads of std::move for header insertion. (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall marked an inline comment as done. sammccall added a comment. In D5#2314596 , @kadircet wrote: > Thanks, LGTM! As you mentioned I believe `std::move` is common enough to > deserve the special casing. Common enough and also literally the

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall updated this revision to Diff 296734. sammccall marked an inline comment as done. sammccall added a comment. Refactor the hack into a more appropriate place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5/new/

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! As you mentioned I believe `std::move` is common enough to deserve the special casing. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:563

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:563 if (auto Header = getIncludeHeader(QName, Entry.second)) { +// Hack: there are two std::move() overloads from different headers. +// CanonicalIncludes

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:563 if (auto Header = getIncludeHeader(QName, Entry.second)) { +// Hack: there are two std::move() overloads from different headers. +// CanonicalIncludes

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Up until now, we relied on matching the