hokein added a comment.
ah, I thought I clicked the accepted button.
anyway, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89131/new/
https://reviews.llvm.org/D89131
___
cfe-commits mailing list
sammccall added a comment.
Sorry, I thought this was accepted. Had addressed the two comments, happy to
address more or revert, LMK
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89131/new/
https://reviews.llvm.org/D89131
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGc2d4280328e4: [clangd]
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Protocol.cpp:800
+ return O && O.map("applied", R.applied) &&
+ O.mapOptional("failureReason", R.failureReason);
}
R.failureReason's type is `llvm::Optional`, I think we should
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
sammccall requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Github
