[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-31 Thread Aaron Ballman via Phabricator via cfe-commits 
aaron.ballman closed this revision.
aaron.ballman added a comment.

In D90109#2366420 , @dsanders11 wrote:

> In D90109#2366415 , @aaron.ballman 
> wrote:
>
>> LGTM! Do you need someone to commit on your behalf?
>
> Yea, I do.

I've commit on your behalf in d915d403d7410b17e8ac52f1f435859713a7b354 
, thank 
you for the patch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-31 Thread David Sanders via Phabricator via cfe-commits 
dsanders11 added a comment.

In D90109#2366415 , @aaron.ballman 
wrote:

> LGTM! Do you need someone to commit on your behalf?

Yea, I do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-31 Thread Aaron Ballman via Phabricator via cfe-commits 
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM! Do you need someone to commit on your behalf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-29 Thread David Sanders via Phabricator via cfe-commits 
dsanders11 added a comment.

> Oh, how neat. The bug you linked to was closed as a dup of another bug. The 
> other bug was then closed as something that's not in scope with the general 
> product direction, whatever that means.

Yea, typical Microsoft/Windows fun there.

> Yeah, that would be reasonable test coverage.

Sounds good. I've updated the revision to remove the `#if` guard and removed 
`REQUIRES: ansi-escape-sequences` from the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-29 Thread David Sanders via Phabricator via cfe-commits 
dsanders11 updated this revision to Diff 301755.
dsanders11 added a comment.

code review changes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

Files:
  clang-tools-extra/clang-tidy/ClangTidy.cpp
  clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
  llvm/lib/Support/Windows/Process.inc


Index: llvm/lib/Support/Windows/Process.inc
===
--- llvm/lib/Support/Windows/Process.inc
+++ llvm/lib/Support/Windows/Process.inc
@@ -327,9 +327,10 @@
   if (enable) {
 HANDLE Console = GetStdHandle(STD_OUTPUT_HANDLE);
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+  SetConsoleMode(Console, Mode);
+}
   }
 #endif
   UseANSI = enable;
Index: clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
===
--- clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
+++ clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
@@ -5,7 +5,6 @@
 // RUN: clang-tidy -config='UseColor: false' -dump-config | FileCheck 
-check-prefix=CHECK-CONFIG-NO-COLOR %s
 // RUN: clang-tidy -help | FileCheck -check-prefix=CHECK-OPT-PRESENT %s
 
-// REQUIRES: ansi-escape-sequences
 // RUN: clang-tidy -checks='-*, modernize-use-override' -extra-arg=-std=c++11 
-use-color=false %s | FileCheck -check-prefix=CHECK-NO-COLOR %s
 // RUN: clang-tidy -checks='-*, modernize-use-override' -extra-arg=-std=c++11 
%s | FileCheck -check-prefix=CHECK-NO-COLOR %s
 // RUN: clang-tidy -checks='-*, modernize-use-override' -extra-arg=-std=c++11 
-use-color %s | FileCheck -check-prefix=CHECK-COLOR %s
Index: clang-tools-extra/clang-tidy/ClangTidy.cpp
===
--- clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -110,6 +110,9 @@
 DiagOpts->ShowColors = Context.getOptions().UseColor.getValueOr(
 llvm::sys::Process::StandardOutHasColors());
 DiagPrinter->BeginSourceFile(LangOpts);
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) 
{
+  llvm::sys::Process::UseANSIEscapeCodes(true);
+}
   }
 
   SourceManager () { return SourceMgr; }


Index: llvm/lib/Support/Windows/Process.inc
===
--- llvm/lib/Support/Windows/Process.inc
+++ llvm/lib/Support/Windows/Process.inc
@@ -327,9 +327,10 @@
   if (enable) {
 HANDLE Console = GetStdHandle(STD_OUTPUT_HANDLE);
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+  SetConsoleMode(Console, Mode);
+}
   }
 #endif
   UseANSI = enable;
Index: clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
===
--- clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
+++ clang-tools-extra/test/clang-tidy/infrastructure/use-color.cpp
@@ -5,7 +5,6 @@
 // RUN: clang-tidy -config='UseColor: false' -dump-config | FileCheck -check-prefix=CHECK-CONFIG-NO-COLOR %s
 // RUN: clang-tidy -help | FileCheck -check-prefix=CHECK-OPT-PRESENT %s
 
-// REQUIRES: ansi-escape-sequences
 // RUN: clang-tidy -checks='-*, modernize-use-override' -extra-arg=-std=c++11 -use-color=false %s | FileCheck -check-prefix=CHECK-NO-COLOR %s
 // RUN: clang-tidy -checks='-*, modernize-use-override' -extra-arg=-std=c++11 %s | FileCheck -check-prefix=CHECK-NO-COLOR %s
 // RUN: clang-tidy -checks='-*, modernize-use-override' -extra-arg=-std=c++11 -use-color %s | FileCheck -check-prefix=CHECK-COLOR %s
Index: clang-tools-extra/clang-tidy/ClangTidy.cpp
===
--- clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -110,6 +110,9 @@
 DiagOpts->ShowColors = Context.getOptions().UseColor.getValueOr(
 llvm::sys::Process::StandardOutHasColors());
 DiagPrinter->BeginSourceFile(LangOpts);
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) {
+  llvm::sys::Process::UseANSIEscapeCodes(true);
+}
   }
 
   SourceManager () { return SourceMgr; }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-29 Thread Aaron Ballman via Phabricator via cfe-commits 
aaron.ballman added a comment.

In D90109#2360538 , @dsanders11 wrote:

>> What issues did you run into regarding testing, because I feel like the 
>> patch should have test coverage (esp given that color vs ANSI escape codes 
>> are a bit of an oddity to reason about)?
>
> I'm unable to create a debug build, due to issues with LLVM and Visual Studio 
> 16.7 
> .
>  There's Google results on the issue, but I don't see any solution and I'm 
> using `master` and the latest version of Visual Studio. It seems you can (and 
> perhaps should?) run the tests with a Release build, so I've gone ahead and 
> done that.

Oh, how neat. The bug you linked to was closed as a dup of another bug. The 
other bug was then closed as something that's not in scope with the general 
product direction, whatever that means.

> I also wasn't seeing any of the test targets being made by CMake until I 
> included `-DLLVM_INCLUDE_TESTS=On`, I think maybe I set that to off when 
> trying to determine why the debug build was failing and didn't realize that 
> would stay in `CMakeCache.txt` until I set it back on.
>
> Removing `REQUIRES: ansi-escape-sequences` from the 
> `clang-tidy/infrastructure/use-color.cpp` test does run it on Windows and 
> does pass as expected with this change. Is that all you're looking for with 
> test coverage?

Yeah, that would be reasonable test coverage.




Comment at: llvm/lib/Support/Windows/Process.inc:330
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;

dsanders11 wrote:
> aaron.ballman wrote:
> > dsanders11 wrote:
> > > Fixes a crash when calling UseANSIEscapeCodes if standard out isn't a 
> > > console.
> > If this fails, do we still want to set `UseANSI` to `enable` below? Similar 
> > if setting the mode fails?
> If we don't set `UseANSI` below then this patch won't do what it's intended 
> to do, since piped stdoutwouldn't have ANSI escape codes. This code block is 
> assuming that standard output is a console, so `GetConsoleMode` won't work on 
> redirected stdout.
> 
> You could use `llvm::sys::Process::StandardOutIsDisplayed()` to check, but 
> for Windows that's actually just doing the same thing, doing a 
> `GetConsoleMode` call and seeing if it succeeds or not.
> 
> For this patch to do what it's intended to do, `UseANSIEscapeCodes` needs to 
> turn on ANSI escape codes even if there isn't a console.
Ah, thank you for the explanation -- my complaint is more that 
`UseANSIEscapeCodes` can fail but doesn't alert the caller to the failure. 
However, that's not a new issue, so I think it's fine as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-28 Thread David Sanders via Phabricator via cfe-commits 
dsanders11 added a comment.
Herald added a subscriber: dexonsmith.

> What issues did you run into regarding testing, because I feel like the patch 
> should have test coverage (esp given that color vs ANSI escape codes are a 
> bit of an oddity to reason about)?

I'm unable to create a debug build, due to issues with LLVM and Visual Studio 
16.7 
.
 There's Google results on the issue, but I don't see any solution and I'm 
using `master` and the latest version of Visual Studio. It seems you can (and 
perhaps should?) run the tests with a Release build, so I've gone ahead and 
done that.

I also wasn't seeing any of the test targets being made by CMake until I 
included `-DLLVM_INCLUDE_TESTS=On`, I think maybe I set that to off when trying 
to determine why the debug build was failing and didn't realize that would stay 
in `CMakeCache.txt` until I set it back on.

Removing `REQUIRES: ansi-escape-sequences` from the 
`clang-tidy/infrastructure/use-color.cpp` test does run it on Windows and does 
pass as expected with this change. Is that all you're looking for with test 
coverage?




Comment at: llvm/lib/Support/Windows/Process.inc:330
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;

aaron.ballman wrote:
> dsanders11 wrote:
> > Fixes a crash when calling UseANSIEscapeCodes if standard out isn't a 
> > console.
> If this fails, do we still want to set `UseANSI` to `enable` below? Similar 
> if setting the mode fails?
If we don't set `UseANSI` below then this patch won't do what it's intended to 
do, since piped stdoutwouldn't have ANSI escape codes. This code block is 
assuming that standard output is a console, so `GetConsoleMode` won't work on 
redirected stdout.

You could use `llvm::sys::Process::StandardOutIsDisplayed()` to check, but for 
Windows that's actually just doing the same thing, doing a `GetConsoleMode` 
call and seeing if it succeeds or not.

For this patch to do what it's intended to do, `UseANSIEscapeCodes` needs to 
turn on ANSI escape codes even if there isn't a console.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits 
dblaikie added a comment.

In D90109#2356317 , @aaron.ballman 
wrote:

> In D90109#2352180 , @dsanders11 
> wrote:
>
>> Added a few inline comments for clarification.
>>
>> **Note**: I was not able to get a debug build and unit tests working on my 
>> Windows set up, so this has only been tested manually. I'm not sure if the 
>> unit test added in D79477  runs on Windows, 
>> but  in theory it should be broken on Windows since it expects ANSI escape 
>> codes in the output.
>
> The functionality test specifies `REQUIRES: ansi-escape-sequences` so I'm 
> guessing that test is not run on Windows. The unit test is parsing 
> configuration options, not exercising the options themselves.
>
> What issues did you run into regarding testing, because I feel like the patch 
> should have test coverage (esp given that color vs ANSI escape codes are a 
> bit of an oddity to reason about)?

+1, I'd expect such a test could unconditionally FileCheck the output to test 
for the escape sequences being present there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits 
aaron.ballman added a comment.

In D90109#2352180 , @dsanders11 wrote:

> Added a few inline comments for clarification.
>
> **Note**: I was not able to get a debug build and unit tests working on my 
> Windows set up, so this has only been tested manually. I'm not sure if the 
> unit test added in D79477  runs on Windows, 
> but  in theory it should be broken on Windows since it expects ANSI escape 
> codes in the output.

The functionality test specifies `REQUIRES: ansi-escape-sequences` so I'm 
guessing that test is not run on Windows. The unit test is parsing 
configuration options, not exercising the options themselves.

What issues did you run into regarding testing, because I feel like the patch 
should have test coverage (esp given that color vs ANSI escape codes are a bit 
of an oddity to reason about)?




Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:113
 DiagPrinter->BeginSourceFile(LangOpts);
+#if defined(_WIN32)
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) 
{

dsanders11 wrote:
> To prevent any unintended changes this has been confined to only Windows, but 
> the code should be safe to run on any platform. I believe it would be a no-op 
> on Unix, which always uses ANSI escape codes and UseANSIEscapeCodes is a 
> no-op.
I agree that the code should work on all supported platforms, I'd say you can 
remove the `#if`.



Comment at: llvm/lib/Support/Windows/Process.inc:330
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;

dsanders11 wrote:
> Fixes a crash when calling UseANSIEscapeCodes if standard out isn't a console.
If this fails, do we still want to set `UseANSI` to `enable` below? Similar if 
setting the mode fails?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-24 Thread David Sanders via Phabricator via cfe-commits 
dsanders11 added a comment.

Added a few inline comments for clarification.

**Note**: I was not able to get a debug build and unit tests working on my 
Windows set up, so this has only been tested manually. I'm not sure if the unit 
test added in D79477  runs on Windows, but  in 
theory it should be broken on Windows since it expects ANSI escape codes in the 
output.




Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:113
 DiagPrinter->BeginSourceFile(LangOpts);
+#if defined(_WIN32)
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) 
{

To prevent any unintended changes this has been confined to only Windows, but 
the code should be safe to run on any platform. I believe it would be a no-op 
on Unix, which always uses ANSI escape codes and UseANSIEscapeCodes is a no-op.



Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:114
+#if defined(_WIN32)
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) 
{
+  llvm::sys::Process::UseANSIEscapeCodes(true);

Limited to only non-displayed standard out so that using '--use-color' from a 
console will be a no-op, rather than turning on ANSI escape codes and making it 
act differently than a default invocation which has color on by default.



Comment at: llvm/lib/Support/Windows/Process.inc:330
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;

Fixes a crash when calling UseANSIEscapeCodes if standard out isn't a console.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-24 Thread David Sanders via Phabricator via cfe-commits 
dsanders11 created this revision.
dsanders11 added reviewers: aaron.ballman, njames93.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, xazax.hun.
Herald added projects: clang, LLVM.
dsanders11 requested review of this revision.

On Windows the --use-color option cannot be used for its originally intended 
purpose of forcing color when piping stdout, since Windows does not use ANSI 
escape codes by default. This change turns on ANSI escape codes on Windows when 
forcing color to a non-displayed stdout (e.g. piped).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90109

Files:
  clang-tools-extra/clang-tidy/ClangTidy.cpp
  llvm/lib/Support/Windows/Process.inc


Index: llvm/lib/Support/Windows/Process.inc
===
--- llvm/lib/Support/Windows/Process.inc
+++ llvm/lib/Support/Windows/Process.inc
@@ -327,9 +327,10 @@
   if (enable) {
 HANDLE Console = GetStdHandle(STD_OUTPUT_HANDLE);
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+  SetConsoleMode(Console, Mode);
+}
   }
 #endif
   UseANSI = enable;
Index: clang-tools-extra/clang-tidy/ClangTidy.cpp
===
--- clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -110,6 +110,11 @@
 DiagOpts->ShowColors = Context.getOptions().UseColor.getValueOr(
 llvm::sys::Process::StandardOutHasColors());
 DiagPrinter->BeginSourceFile(LangOpts);
+#if defined(_WIN32)
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) 
{
+  llvm::sys::Process::UseANSIEscapeCodes(true);
+}
+#endif
   }
 
   SourceManager () { return SourceMgr; }


Index: llvm/lib/Support/Windows/Process.inc
===
--- llvm/lib/Support/Windows/Process.inc
+++ llvm/lib/Support/Windows/Process.inc
@@ -327,9 +327,10 @@
   if (enable) {
 HANDLE Console = GetStdHandle(STD_OUTPUT_HANDLE);
 DWORD Mode;
-GetConsoleMode(Console, );
-Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-SetConsoleMode(Console, Mode);
+if (GetConsoleMode(Console, ) != 0) {
+  Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+  SetConsoleMode(Console, Mode);
+}
   }
 #endif
   UseANSI = enable;
Index: clang-tools-extra/clang-tidy/ClangTidy.cpp
===
--- clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -110,6 +110,11 @@
 DiagOpts->ShowColors = Context.getOptions().UseColor.getValueOr(
 llvm::sys::Process::StandardOutHasColors());
 DiagPrinter->BeginSourceFile(LangOpts);
+#if defined(_WIN32)
+if (DiagOpts->ShowColors && !llvm::sys::Process::StandardOutIsDisplayed()) {
+  llvm::sys::Process::UseANSIEscapeCodes(true);
+}
+#endif
   }
 
   SourceManager () { return SourceMgr; }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits