[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-19 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-19 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo updated this revision to Diff 306482. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-19 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4023 + D.Diag(diag::err_drv_argument_only_allowed_with) + << A->getAsString(Args) << "DWARVv3 or greater"; +else if (!RawTriple.isArch64Bit())

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-19 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo updated this revision to Diff 306477. ayermolo marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread Igor Kudrin via Phabricator via cfe-commits
ikudrin added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo updated this revision to Diff 306263. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4020 +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); +const llvm::Triple = TC.getTriple(); +if (DWARFVersion < 3) MaskRay wrote: > The variable is only used

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

2020-11-18 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo updated this revision to Diff 306223. ayermolo retitled this revision from "Adding DWARF64 clang flag" to "Adding DWARF64 clang flag: -gdwarf64". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507