keith added a comment.
Yea seems like a reasonable request, looking through the uses nothing
immediately pops out as being not supporting multiple PCHs but I guess before I
went down that path I'd want someone who knew the code better to agree on that
Repository:
rG LLVM Github Monorepo
kastiglione added a comment.
Is there any reason that `-include-pch` shouldn't follow the precedent of
`-include`, which can be used multiple times? If not, then the end goal should
be to support multiple uses, but in the mean time a warning is helpful.
Repository:
rG LLVM Github Monorepo
keith added a comment.
Fair question! I think this case is a bit different since it's quite subtle.
The strange thing here is that the header you're intending to provide a pch for
can still be read successfully, but not getting the benefits of the pch that
you were expecting without knowing
MaskRay added a comment.
There are many options whether the latter one overrides the previous ones. How
is this special?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90646/new/
https://reviews.llvm.org/D90646
keith updated this revision to Diff 319138.
keith added a comment.
Herald added a reviewer: jansvoboda11.
Add group to warning
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90646/new/
https://reviews.llvm.org/D90646
Files:
keith created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
keith requested review of this revision.
Previously this argument passed multiple times would result in the first
being silently ignored.
Repository:
rG LLVM Github Monorepo
