This revision was automatically updated to reflect the committed changes.
Closed by commit rGfb58142e00ad: Fix temporary file name on Windows (authored
by yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D91421?vs=305127=305352#toc
Repository:
rG
yaxunl added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4645
+ // therefore replace it with '%'.
+ std::replace(BoundArch.begin(), BoundArch.end(), ':', '%');
+#endif
tra wrote:
> Windows `cmd` shell uses `%` to reference environment variables.
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM overall, nit about the character choice.
Comment at: clang/lib/Driver/Driver.cpp:4645
+ // therefore replace it with '%'.
+ std::replace(BoundArch.begin(), BoundArch.end(),
yaxunl updated this revision to Diff 305127.
yaxunl added a comment.
add end of line to test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91421/new/
https://reviews.llvm.org/D91421
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/hip-windows-filename.hip
Index:
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl requested review of this revision.
Bound arch may contain ':', which is invalid in Windows file names.
This patch fixes that.
https://reviews.llvm.org/D91421
Files:
clang/lib/Driver/Driver.cpp
