[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c696a212ba4: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors (authored by joechrisellis). Repository: rG LLVM Github Monorepo

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

c-rhodes accepted this revision. c-rhodes added a comment. In D91696#2405082 , @joechrisellis wrote: > Address @c-rhodes's comments regarding lax conversion when > __ARM_FEATURE_SVE_BITS != N for GNU vectors. Cheers, LGTM Repository: rG LLVM Github

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:278-283 -// Test implicit conversion between SVE and GNU vector is invalid when -// __ARM_FEATURE_SVE_BITS != N -#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis updated this revision to Diff 306351. joechrisellis marked an inline comment as done. joechrisellis added a comment. Address @c-rhodes's comments regarding lax conversion when __ARM_FEATURE_SVE_BITS != N for GNU vectors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

c-rhodes added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:278-283 -// Test implicit conversion between SVE and GNU vector is invalid when -// __ARM_FEATURE_SVE_BITS != N -#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512 -typedef

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. This LGTM. May I ask to extend the commit message to add a reference to the paragraph in section "3.7.3.3", item 2 on page 23 of the specs version 00bet6? Repository: rG LLVM

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis updated this revision to Diff 306043. joechrisellis added a comment. Remove redundant tests from clang/test/Sema/attr-arm-sve-vector-bits.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91696/new/ https://reviews.llvm.org/D91696

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

willlovett added a comment. I found this one. The fix looks sensible, and I believe the test is correct and consistent with the spec. I'll leave it to someone else to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91696/new/

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis created this revision. joechrisellis added reviewers: fpetrogalli, peterwaller-arm. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis requested review of this revision. Previously,