[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc90dac27e94e: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best. (authored by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. Thank you for the review! I'll put a note in my cal to land this in a few days if I don't hear from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert accepted this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me. Maybe wait a few days whether @rsmith has a comment before you land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. > I guess I was confused by the function name Haha, two hardest problems in computer science. :) Changed it to `S.Diags.overloadCandidatesShown(ShownOverloads);` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar updated this revision to Diff 325158. jlebar added a comment. Rename noteNumOverloadCandidatesShown -> overloadCandidatesShown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754 Files:

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + jlebar wrote: > aaronpuchert wrote: > > jlebar wrote: > > > aaronpuchert wrote: > > > > Why not in the following `if`? I

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + aaronpuchert wrote: > jlebar wrote: > > aaronpuchert wrote: > > > Why not in the following `if`? I assume we want to show a long

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + jlebar wrote: > aaronpuchert wrote: > > Why not in the following `if`? I assume we want to show a long list not > >

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. Thank you for your comments, Aaron! Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + aaronpuchert wrote: > Why not in the following `if`? I assume we want to show a long list not >

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert added a comment. In D95754#2561849 , @jlebar wrote: > Not sure who can review this, but looking through blame it seems like maybe > @aaronpuchert? I'm by no means an expert on overloading, but this seems more like a usability question. I

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. Not sure who can review this, but looking through blame it seems like maybe @aaronpuchert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar created this revision. jlebar requested review of this revision. Herald added a project: clang. Previously, -fshow-overloads=best always showed 4 candidates. The problem is, when this isn't enough, you're kind of up a creek; the only option available is to recompile with different flags.