https://github.com/labrinea closed
https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilinpv approved this pull request.
Thanks for tests!
https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea updated
https://github.com/llvm/llvm-project/pull/83887
>From f11c97d7f7f67edaf6de4390bcceb13dfea376a1 Mon Sep 17 00:00:00 2001
From: Alexandros Lamprineas
Date: Mon, 4 Mar 2024 18:12:22 +
Subject: [PATCH] [FMV] Allow target version definitions in any order.
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11455,9 +11465,8 @@ static bool CheckTargetCausesMultiVersioning(Sema ,
FunctionDecl *OldFD,
}
// If this is 'default', permit the forward declaration.
- if (!OldFD->isMultiVersion() &&
- ((NewTA && NewTA->isDefaultVersion() && !OldTA) ||
- (NewTVA &&
@@ -11455,9 +11465,8 @@ static bool CheckTargetCausesMultiVersioning(Sema ,
FunctionDecl *OldFD,
}
// If this is 'default', permit the forward declaration.
- if (!OldFD->isMultiVersion() &&
- ((NewTA && NewTA->isDefaultVersion() && !OldTA) ||
- (NewTVA &&
@@ -11429,6 +11429,16 @@ static bool CheckTargetCausesMultiVersioning(Sema ,
FunctionDecl *OldFD,
bool ,
NamedDecl *,
LookupResult ) {
+
https://github.com/ilinpv requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilinpv edited https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
Thank you, this is great!
https://github.com/llvm/llvm-project/pull/83887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea updated
https://github.com/llvm/llvm-project/pull/83887
>From 65a192641b5856714b9247372d9c471e03520762 Mon Sep 17 00:00:00 2001
From: Alexandros Lamprineas
Date: Mon, 4 Mar 2024 18:12:22 +
Subject: [PATCH] [FMV] Allow target version definitions in any order.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bd7bce2c8465e9cb36a823846a52c9f553502575
5a717769aa20dfbbaa8edd4bcd3048ebedee20a2 --
labrinea wrote:
I appreciate there's some code repetition between
`CheckTargetCausesMultiVersioning` and `CheckMultiVersionAdditionalDecl`.
Perhaps they deserve some refactoring in a separate patch. Please advise if you
have any suggestions for moving the fix elsewhere.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alexandros Lamprineas (labrinea)
Changes
This patch fixes #71698. It allows defining the default target version
prior to other version definitions without raising semantic errors.
---
Full diff:
https://github.com/labrinea created
https://github.com/llvm/llvm-project/pull/83887
This patch fixes #71698. It allows defining the default target version prior to
other version definitions without raising semantic errors.
>From 5a717769aa20dfbbaa8edd4bcd3048ebedee20a2 Mon Sep 17 00:00:00
16 matches
Mail list logo
