[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
https://github.com/Shakil582 closed https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
https://github.com/HazardyKnusperkeks requested changes to this pull request. You shouldn't do that in ClangFormat.cpp, because tools which use libformat directly would suddenly behave different as clang-format. https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
https://github.com/mydeveloperday commented: why can't the OnWords/Offwords be treated identically to how //clang-format off/on is handled. https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
@@ -26,6 +26,12 @@ #include "llvm/Support/InitLLVM.h" #include "llvm/Support/Process.h" #include +#include +#include +#include +#include mydeveloperday wrote: why do we need OpenMP constants here? https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
https://github.com/mydeveloperday requested changes to this pull request. Your are missing the config part from what I can tell, also unit test and documentation https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
@@ -26,6 +26,12 @@ #include "llvm/Support/InitLLVM.h" #include "llvm/Support/Process.h" #include +#include mydeveloperday wrote: why do you need iostream? did you have some std::cerr << debug output that you've now removed but you've left the header? https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
mydeveloperday wrote: Before we could consider this your code would need unit tests and changes to the documentation to accompany the change. https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format] Add additional custom words for equivalent clang-format on/off functionality (PR #123543)
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/123543 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
